Skip to content

ci(release): peel the release tag via the git refs API #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EraPartner merged 5 commits into from
Oct 28, 2026
Merged

ci(release): peel the release tag via the git refs API #385

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d45263b
fix(packaging): resolve bare ICU install names beside the source dylib
claude Oct 28, 2026
8cc3d14
fix(packaging): thin Postgres.app binaries and drop unshipped files
claude Oct 28, 2026
3cb9a0c
chore(merge): bring main into claude/project-thread-nu4294
claude Oct 28, 2026
66ddce7
chore(merge): bring main into claude/project-thread-nu4294
claude Oct 28, 2026
a5cc90a
ci(release): peel the release tag via the git refs API
claude Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,18 @@ jobs:
set -euo pipefail
# The release tag must still name the reviewed commit when the draft
# becomes public. `gh release edit` is the final publication step.
ACTUAL_COMMIT=$(gh api "repos/${GITHUB_REPOSITORY}/commits/tags/${TAG}" --jq '.sha')
# The commits API rejects tags/<name> for annotated tags (HTTP 422);
# peel the tag ref to its commit instead.
tag_commit() {
local object
object=$(gh api "repos/${GITHUB_REPOSITORY}/git/ref/tags/${TAG}" --jq '.object.type + " " + .object.sha')
while [ "${object%% *}" = tag ]; do
object=$(gh api "repos/${GITHUB_REPOSITORY}/git/tags/${object#* }" --jq '.object.type + " " + .object.sha')
done
[ "${object%% *}" = commit ] || return 1
echo "${object#* }"
}
ACTUAL_COMMIT=$(tag_commit)
if [ "$ACTUAL_COMMIT" != "$EXPECTED_COMMIT" ]; then
echo "ERROR: release tag changed after verification"
exit 1
Expand Down Expand Up @@ -451,7 +462,7 @@ jobs:
echo "ERROR: published release is not immutable"
exit 1
fi
if [ "$(gh api "repos/${GITHUB_REPOSITORY}/commits/tags/${TAG}" --jq '.sha')" != "$EXPECTED_COMMIT" ]; then
if [ "$(tag_commit)" != "$EXPECTED_COMMIT" ]; then
retract_if_mutable
echo "ERROR: published release tag does not point to the verified commit"
exit 1
Expand Down