Repository navigation
ci: fail when the standalone backend lockfile drifts from apps/backend/package.json - #143
Merged
Merged
Conversation
…d/package.json Dependabot only updates the root lockfile, so backend bumps (e.g. #135, undici) left apps/backend/package-lock.json stale and the desktop bundle's npm ci would refuse it. Adds an offline spec comparison as a step in the existing Verify Generated Artifacts job (no new job).
Coverage Report
File CoverageNo changed files found. |
Coverage Report for backend
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
apps/desktop/scripts/stage-backend.mjsrunsnpm ciagainst the standaloneapps/backend/package-lock.json. Dependabot version updates only touch the root lockfile. So a backend bump leaves the standalone file behind, and the desktop build'snpm cithen refuses it. Examples: #135 leftundiciat^8.5.0vs^8.12.3, and before #140 it was zod.Decision
The owner picked this option on a decision card. The card stated it adds one step to an existing job. The alternatives were generating the lockfile at build time (loses pinning) and leaving things as they are.
apps/backend/package.jsonwithpackages[""]in the standalone lockfile. No network, no install.CI time added
The CI log for run 40654622578, job Verify Generated Artifacts, shows the step taking about 0.04 s: it starts at 08:08:40.709 and prints its result at 08:08:40.744. Total job time is unchanged at 39 s.
Changes
scripts/verify-backend-lockfile.mjs(new)package.json:verify:backend-lockfilescript.github/workflows/ci.yml: one step inVerify Generated Artifactsdocs/guides/running-the-desktop-app.md,CHANGELOG.md: notesVerification
undici^8.12.3vs^8.5.0.undicirange in package.json: fails with exit 1..prettierrcby hand.🤖 Generated with Claude Code
https://claude.ai/code/session_018QJtaLhrRDgpPKoydMiPCx