You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Revalidate EOS-CG phase assertion in CO2 low-temperature notebook #151
A documentation-only catalog update in draft PR #150 triggered the existing CO2 low-temperature notebook validation workflow. The workflow is master-dependent and failed while executing:
The notebook was last recorded as passing against NeqSim commit ef31a3ba78a325b5784a33486bb047a264425412.
Failure
All checks passed except:
EOS-CG detects nominal two-phase state at 25 C: False
The assertion expects two phases for the notebook's nominal state at 70 bara and 25 °C with 1 mol% total impurity split as 50% nitrogen, 30% oxygen, and 20% argon. The retained validated notebook reports two phases and gas beta 0.03087 for that state; the current-master execution no longer satisfies getNumberOfPhases() == 2.
Requested investigation
Reproduce the state against commits ef31a3b and fdf6b22.
Identify whether the phase-count change is an intended EOS-CG correction, a flash/model regression, or an overly brittle notebook acceptance point.
If intended, update the notebook's physical interpretation, validation condition, retained outputs, and ledger with an independently justified phase-boundary comparison.
If unintended, open/link an actionable equinor/neqsim defect and pin the notebook workflow only as a temporary measure.
Restore the existing workflow to green against its declared source policy.
Acceptance criteria
The expected phase behavior at the exact nominal state is documented with commit provenance.
The check tests a physically justified property rather than simply weakening the assertion.
The notebook is cleanly re-executed, rendered, and visually reviewed.
Reproduced assertion: EOS-CG detects nominal two-phase state at 25 C: False
The other eleven scientific assertions displayed by the cell passed on both attempts.
The draft changes only comparesimulations2.ipynb and its two maintenance-ledger files; it does not modify the CO₂ notebook, its workflow, or NeqSim thermodynamic sources. This confirms the failure remains an independent source-policy/phase-behavior dependency rather than a branch-attributable defect in #156.
The acceptance criteria and requested physical investigation in this issue remain appropriate. No assertion was weakened and no thermodynamics change was folded into the engineering-diagram draft.
Activity
EvenSol commentedon Sep 9, 2026
Reproduction update — 2026-09-09
Draft #156 reproduced this unchanged-notebook failure against a newer NeqSim source state:
308fd1e690eac4d188275c2e862b9d3d6ee6f1fdad9b7251d4fcc111b7e80dee49cd0941d8317029b943296EOS-CG detects nominal two-phase state at 25 C: FalseThe draft changes only
comparesimulations2.ipynband its two maintenance-ledger files; it does not modify the CO₂ notebook, its workflow, or NeqSim thermodynamic sources. This confirms the failure remains an independent source-policy/phase-behavior dependency rather than a branch-attributable defect in #156.The acceptance criteria and requested physical investigation in this issue remain appropriate. No assertion was weakened and no thermodynamics change was folded into the engineering-diagram draft.