Repository navigation
Add Dholabhai hydrate comparisons and salt-specific accuracy discussion - #189
Merged
Merged
Conversation
EvenSol
marked this pull request as ready for review
October 5, 2026 21:26
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hydrate tutorial's repaired KCl solver returns a numerical boundary, but its previous external benchmark only covered NaCl. This update adds independent comparison and discussion against Dholabhai, Kalogerakis & Bishnoi (1993), doi:10.1021/je00012a045.
Comparison
All 110 points converge, conserve input and meet the saturated GAS+AQUEOUS comparison requirements. This is numerical acceptance, not an experimental accuracy claim. Matched K10 predicts -2.546515 °C versus measured -4.130 °C, a +1.583485 K error. NaCl RMSE is 0.324862 K, KCl 2.685082 K, and concentrated KCl errors reach 6.729004 K. Per-recipe metrics keep opposing mixed-salt biases visible.
The actionable accuracy limitation is tracked by equinor/neqsim#4234, under #3144. No parameters are fitted and no empirical mud correction is applied to these measurements. The five synthetic-seawater endpoints are excluded because their complete salt recipe is outside the three-salt builder. The supplied ACS PDF and original figures are not redistributed.
Validation
f59810115c07d9a3ef479e55be45a5972963231d, source-built Java 3.23.0, Python bridge 3.20.0. Verified reused JAR SHA-256e26d9dd82e86d351fa58fe05e04801e2af6aebb17d19081c690736d924536f19; cached source files matched the clean immutable checkout, and class origin was asserted.17c0beca5a5ca53401fa214c2a542892e5a6a467was inspected; no thermo/hydrate/electrolyte/database changes from the tested pin. That newer head was not rebuilt.scripts/check_notebook.py --require-main-sourcewith the updated ledger and affected-link catalog: 0 errors, 0 warnings.Documentation impact
The existing notebook gains the measured comparison, scientific discussion, sources, exports and accuracy follow-up. Its catalog description and maintenance ledger are updated in the same branch. No NeqSim Java API, model equations, parameters or defaults change.
Open this draft in Colab