Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an executed, source-pinned Colab study following the response-surface method described in equinor/neqsim#4253. It compares PipeBeggsAndBrills and TwoFluidPipe and includes a fixed-temperature homogeneous AdiabaticPipe diagnostic. All design cases are synthetic; the public ASME abstract does not supply the paper's numerical dataset, so this is not a reproduction of its results or experimental model qualification.
The notebook solves hydraulic rates for a 100-to-80 bara receiving-pressure constraint across diameter, horizontal length and methane/decane composition. It retains all 15 executed code cells, 86 accepted rate roots, complete tables, three plots, surrogate coefficients, analytical and mesh checks, runtime provenance, and CSV/JSON export code. There are 27 training designs and 16 off-grid held-out designs per multiphase model. Every final root is replayed and checked; invalid TwoFluidPipe candidates never enter training.
At the 40 km / 0.35 m / 6 mol% decane baseline, rates are 40.38 kg/s (Beggs–Brill) and 44.04 kg/s (TwoFluidPipe). Model disagreement reaches 16.15% across the cases. A physics-informed quadratic correction reduces worst held-out surrogate error from 11.65% to 0.52% for Beggs–Brill and from 15.04% to 2.17% for TwoFluidPipe. Out-of-domain requests fall back to NeqSim. These errors are against each simulator, not against measurements.
Validation
1768fc1fec78ff974fe9ff4232582f09ed504686, source-built 3.23.0 JAR with SHA-256 and class-location assertions.scripts/execute_notebook_inprocess.py; final notebook has sequential counts, retained outputs, zero stored errors and zero stderr.Maven -DskipTests -Dmaven.javadoc.skip=true package: exit 0.Maven -Dtest=TwoFluidPipeSteadyStateConvergenceTest,PipeBeggsAndBrillsBoundaryTest test: six tests, zero failures/errors.scripts/check_notebook.py --require-main-source, using the focused new ledger and validation catalog: zero errors/warnings. NeqSim skill notebook checker, notebook schema, AST, <=100-character code lines and compact Colab math checks pass.NeqSim improvements
Verified and filed equinor/neqsim#4258: the native Beggs–Brill flow-rate solver returns normally on iteration exhaustion with a +0.43722 bar pressure residual versus its 0.008 bar tolerance. The notebook reproduces that defect separately and excludes it from all accepted design/training results.
Existing equinor/neqsim#2907, #4228 and #3298 are linked for public pressure-drop/holdup benchmarks, common network evidence and thermal/terrain/transient qualification. The public-case adapter requires source/reuse/units/uncertainty evidence and explicitly supports only the demonstrated binary, horizontal, isothermal setup. No duplicate campaign issues were created.
Documentation impact
Adds the notebook to README and the main examples catalog, introduces a dedicated maintenance-ledger shard and increments the active count from 321 to 322. Assumptions, installation/source provenance, evidence boundaries, output interpretation and improvement acceptance criteria are documented in the notebook.
Hosted-Colab downloads/source compilation have not been exercised locally; clean validation uses the exact source-built JAR through the documented local overrides. Experimental data, reservoir/well deliverability, heat loss, shore rise, equipment limits and transient operability remain outside this bounded hydraulic study.
Refs equinor/neqsim#4253. The research issue remains open because published-data validation is still outstanding.