fix(lancedb): keep FTS migration nonblocking#344
Draft
SiyaoZheng wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the one-time FTS schema migration from performing synchronous marker-file I/O inside its async startup path.
migrate_fts_indexes()previously calledpathlib.Path.exists(),read_text(), andwrite_text()directly. On a slow or busy filesystem these calls block the event loop during service startup. This change wraps the marker inanyio.Pathand awaits the file operations while preserving the existing migration/version semantics.Area
Verification
Checklist
main..envfiles, dependency folders, or generated output.Notes for Reviewers
The tests verify async marker reads and writes for both the migration and already-migrated paths.
By submitting this pull request, I agree that my contribution is licensed under the Apache License 2.0.