Skip to content

fix(review): release collected agents before follow-on work - #1649

Merged
tmchow merged 4 commits into
mainfrom
tmchow/fix-ce-work-codex
Sep 9, 2026
Merged

fix(review): release collected agents before follow-on work#1649
tmchow merged 4 commits into
mainfrom
tmchow/fix-ce-work-codex

Conversation

@tmchow

@tmchow tmchow commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Completed review agents can exhaust the harness limit and prevent the next review from starting. ce-doc-review, ce-simplify-code, and ce-code-review now require collection followed by caller-owned release before subsequent batches or handoffs, including code-review validators.

The guidance uses the active harness’s lifecycle capabilities and avoids messages to completed agents with no remaining work. When release is unavailable, it reports retained capacity. Document review stops as incomplete if selected reviewers cannot dispatch and capacity cannot recover; it preserves collected outcomes and names the missing coverage. Planning propagates that incomplete review through its existing blocked result. Started cross-model jobs are collected and cleaned up before any return, with recovery limited to reviews that can still proceed to synthesis. This does not repair upstream scheduler retention.

Related: openai/codex#34518, openai/codex#39694

Validation

  • bun run test: 3,841 passed, zero failures; release and strict plugin validation passed.
  • Fresh Claude and Codex runs completed the simplification reviewer stage before and after the change. Post-change Codex correctly reported that release was unavailable and capacity release remained unverified.
  • Both hosts passed lifecycle decision checks for successful and failed reviewers, a still-running reviewer, unavailable release, validator handoff, and the early classifier exit. An incomplete-review consumer probe returned the existing blocked result on both hosts after the planning handoff was clarified. Peer cleanup and recovery decision checks also passed on both hosts for incomplete return and normal synthesis. Actual explicit agent release and the upstream retention failure were not reproduced.

Security Disclosure

No security-relevant changes.

Agent Disclosure

  • Model: Codex · GPT-6

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T20:34:41.860136Z d2ba29d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1cde31cbf0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/ce-doc-review/references/dispatch.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d932b6057d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/ce-code-review/references/dispatch-reviewers.md Outdated
Comment thread skills/ce-doc-review/SKILL.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c72fd774ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/ce-doc-review/SKILL.md Outdated
@tmchow
tmchow merged commit b3efbd6 into main Sep 9, 2026
4 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant