Skip to content

fix(test): pull the node recovery stand-in image on each kind node - #188

Merged
Mearman merged 2 commits into
mainfrom
fix/node-recovery-kind-image
Nov 3, 2026
Merged

Mearman merged 2 commits into
mainfrom
fix/node-recovery-kind-image

Conversation

@Mearman

@Mearman Mearman commented Nov 3, 2026

Copy link
Copy Markdown
Member

The Recovery in kind job fails on main and on every branch touching the watcher: kind load docker-image imports the pulled busybox:1.36 with --all-platforms, and ctr reports content digest sha256:71b0cbca...: not found. The runner's Docker pulls a multi-platform index but holds only its own platform's blobs.

The test now loads only the locally built watcher image and has each kind node pull the stand-in image through crictl. The workflow run on this branch is the check.

A host Docker on the containerd image store pulls a multi-platform index that holds only the
host platform's blobs, so kind's import of it with all platforms fails on a missing digest.
Each node now pulls the image through its own runtime and only the locally built watcher
image is loaded from the host.
@Mearman
Mearman marked this pull request as ready for review November 3, 2026 09:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ⚠️ Failed 2026-11-03T10:00:11.058900Z
We couldn’t complete this review. Comment @codex security review to try again.
06ab489 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@Mearman

Mearman commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@Mearman
Mearman merged commit fa96020 into main Nov 3, 2026
15 checks passed
@Mearman
Mearman deleted the fix/node-recovery-kind-image branch November 3, 2026 10:00
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 2.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant