Repository navigation
fix(cluster): read node readiness under check mode so the wait can judge it - #203
Merged
Merged
Conversation
…dge it The two kubectl reads that feed the wait were skipped under --check, leaving an empty node list that the wait reported as no registered node. They change nothing, so they now run in check mode.
Mearman
force-pushed
the
fix/check-mode-node-reads
branch
from
November 3, 2026 17:42
e4fc52d to
87eb527
Compare
Mearman
marked this pull request as ready for review
November 3, 2026 18:08
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
|
🎉 This PR is included in version 2.28.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nodes' Ready state is read with two read-only kubectl calls that were skipped under --check, so the wait failed with no registered node on a check run. They now run in check mode, with a test that runs the wait under --check. Regression from the inventory-scoped wait in PR 197.