Repository navigation
feat(arc): leave a role swap's nodes and regraded servers alone in node-recovery - #209
Merged
Merged
Conversation
…ade level label A Role in the Lease's namespace allows get on the one Lease that serialises voter swaps and regrading, and nothing else there. The watcher is told the Lease, the annotation that lists a swap's nodes and the level label through its environment; the level label follows the cluster role's setting.
…de-recovery While the fleet-regrade Lease is unexpired, node-recovery neither taints nor prunes a node its swap-nodes annotation lists or its holder names, and it never taints a node carrying the regrade level label. A swap or a regrade step makes a node silent on purpose, and an out-of-service taint would evict pods the controller is draining deliberately. A taint applied earlier is still cleared once the node is Ready, and a Lease that cannot be read fails the pass before any change. Refs #183
Mearman
marked this pull request as ready for review
November 3, 2026 21:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
|
🎉 This PR is included in version 2.32.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-recovery gave a silent node the out-of-service taint after the threshold, whatever the reason it was silent. A voter swap and a regrade step both make a node silent on purpose, so the taint would evict pods the controller is draining deliberately.
While the
kube-system/fleet-regradeLease is unexpired, node-recovery now neither taints nor prunes a node itsgithub-runner.exadev.com/swap-nodesannotation lists or its holder names. A node carrying the regrade level label is never tainted. A taint applied earlier is still cleared once the node is Ready. The Lease is read through a Role withgeton that one name; a Lease that cannot be read fails the pass before any change.The expiry rule is
lease_state's from the regrade core, reimplemented in the script's jq. The level label followsgithub_runner_cluster_regrade_level_label, as the role controller's does. The Lease name, namespace and annotation key are fixed names invars/main.yml.Refs #183