drop node-fetch and simplify codebase#21
Closed
ChALkeR wants to merge 1 commit into
Closed
Conversation
ChALkeR
force-pushed
the
chalker/no-node-fetch
branch
2 times, most recently
from
August 3, 2024 13:27
9f1d23a to
23997ad
Compare
ChALkeR
marked this pull request as draft
August 3, 2024 14:03
ChALkeR
force-pushed
the
chalker/no-node-fetch
branch
2 times, most recently
from
August 9, 2024 10:20
7c7bf0f to
536e9d6
Compare
ChALkeR
force-pushed
the
chalker/no-node-fetch
branch
from
August 30, 2024 13:14
536e9d6 to
e678b9a
Compare
Contributor
Author
|
Closing in favor of #25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would have been a semver-major, but I propose to treat Node.js versions unsupported by upstream as unsupported here even in terms of semver-major breakages
Then,
node-fetchis not actually used on any platform since #20, so it can be removed, and code simplified