build: make toolchain checks portable on Windows - #558
Closed
bamboo0403 wants to merge 1 commit into
Closed
Conversation
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 2 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
這個 PR 做了什麼
讓 mise 工具鏈 ownership 與 executable-bit 檢查可在 Windows Git Bash 正確運作，同時維持 macOS 與 Linux 的既有檢查。
相關 issue
怎麼驗
在 Windows Git Bash 執行：
mise which flutter mise where flutter tool/check/tooling.sh mise exec -- flutter analyze tool/run.sh檢查清單
tool/check/commits.sh origin/main..HEAD通過—— commit 訊息就是更新日誌，格式見 commit.md
mise exec -- flutter analyze與mise exec -- flutter test通過AppLocalizations，沒有寫死AppSpacing/AppRadius/AppMotion，深色模式看過，文字對比度可接受