[Payment due @daledah] Upgrade metro to 0.84.5 and image-size to 2.0.4 to fix Dependabot alerts by MelvinBot · Pull Request #103025 · Expensify/App

MelvinBot · 2026-10-05T12:38:27Z

Explanation of Change

Fixes Dependabot alerts for image-size (GHSA-w3rx-r6r6-pgpr, GHSA-m5qc-5hw7-8vg7). No 1.x release fixes the ICNS bug, so we move off 1.x:

metro / metro-transform-plugins 0.84.4 → 0.84.5. Metro 0.84.5 drops image-size for vendored parsers. @expo/metro resolves to 56.0.2 (pins metro 0.84.5, within the existing ~56.0.0 range).
Override image-size → 2.0.4 for its last user, @callstack/repack. Re.Pack calls the named imageSize(buffer) export, which v2 keeps.
Renamed the metro and metro-runtime patches to 0.84.5. The patched files are byte-identical between 0.84.4 and 0.84.5.

AI tests: none run locally. npm install was unavailable, so I updated the lockfile by hand from registry metadata (integrity hashes and dependencies). CI npm ci validates it.

How it's used: build-time only, never shipped to clients. Metro (opt-in with BUNDLER=metro) and Re.Pack (the default native bundler) read local image assets to get their width and height for require('./img.png').

Change Log

image-size 1.1.1 / 1.2.1 → 2.0.4

2.0.3/2.0.4: fix ICNS parser infinite loop (GHSA-w3rx-r6r6-pgpr)
2.0.2 / 1.2.1: fix DoS via crafted payloads (GHSA-m5qc-5hw7-8vg7)
2.0.0: dual CJS/ESM, Uint8Array input, zero dependencies, drops sync file-path API

metro 0.84.4 → 0.84.5 (release)

Replace image-size dependency with vendored parsers, fix CVE alerts (facebook/metro#1860)

@expo/metro 56.0.0 → 56.0.2

Bumps pinned metro packages to 0.84.5

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/688707
PROPOSAL:

Tests

npm ci. Verify patch-package applies metro+0.84.5.patch and metro-runtime+0.84.5.patch without errors.
npm ls image-size metro. Verify only image-size@2.0.4 and metro@0.84.5 are installed.
npm run ios and npm run android (Re.Pack). Verify local images (logos, illustrations, avatars) render with the correct size.
BUNDLER=metro npm run ios. Verify the bundle loads and local images render.
Edit a worklet file while the app runs. Verify Fast Refresh picks up the change.
Build a release bundle (npm run android-build) and verify it succeeds.

Verify that no errors appear in the JS console

Offline tests

N/A, build tooling only.

QA Steps

On iOS and Android, open the app and browse Inbox, Settings and Workspaces.
Verify that bundled images and illustrations render at the correct size.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…dabot alerts

melvin-bot · 2026-10-05T12:38:35Z

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-10-05T12:49:24Z

The failing check is unrelated to this PR, so I didn't push a change.

Analysis: Only test (job 1) fails. Nine tests in tests/unit/hooks/useGettingStartedItems.test.ts fail with ReferenceError: Request is not defined. The error comes from expo's fetch polyfill, called from src/libs/HttpUtils.ts. Every Jest run started since about 12:37 UTC today fails the same 9 tests. That includes PRs that change no dependencies, such as [POC] oxlint - with scripts.

Evidence: This PR only changes package.json, package-lock.json, and the metro patches. The lockfile changes only bump metro to 0.84.5 and image-size to 2.0.4. None of these touch Jest, expo, fetch, or the failing test.

Details

Failing run: Jest Unit Tests, test (job 1)
Same failure, same 9 tests, on these runs: claude-bumpPdfjsDist (Bump pdfjs-dist to 6.3.289 to address security advisory), claude-updateUndici, claude-bumpFastXmlParser, claude-upgradeXlsxSecurity, and feat/oxlint.
Jest runs started before 12:37 UTC passed, and they used the same main commit. The only commit on main today merged at 12:00 UTC. So the cause looks environmental or time-dependent, not tied to a code change.
Check independent approval also fails, but that check only needs a reviewer's approval.
I couldn't run Jest locally in this environment. The conclusion rests on the CI logs above.

Next step: Re-run the failed job once the shared failure on main is fixed. If it keeps failing, someone should look at why useGettingStartedItems.test.ts makes a real fetch call without a mock.

daledah · 2026-10-06T03:13:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

daledah · 2026-10-06T03:24:29Z

@MelvinBot please merge main

MelvinBot · 2026-10-06T03:27:38Z

I didn't merge main into this branch. A merge pushes a new commit, and I can only push to a PR when the PR author, an assignee, or an existing co-author asks.

To have me merge main, the PR assignee (amyevans) should reply tagging me with the same request.

view run

daledah

LGTM

melvin-bot · 2026-10-06T07:46:13Z

🎯 @daledah, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/688707.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

…lnerability Co-authored-by: Amy Evans <amyevans@users.noreply.github.com>

MelvinBot · 2026-10-06T07:56:33Z

I merged main into this branch, which fixes the failing test (job 1) check. The fix is in commit 8e58a33.

The failing test was not caused by this PR. tests/unit/hooks/useGettingStartedItems.test.ts sent a real GetRules request without mocking fetch, so it threw ReferenceError: Request is not defined. [No QA] Mock fetch in useGettingStartedItems tests so GetRules stays off the network already fixed this on main. This branch was 501 commits behind main.

The merge applied cleanly. The PR diff is unchanged: the metro 0.84.5 bump, the image-size 2.0.4 override, and the renamed patches. The checklist and Check independent approval failures need reviewer action, not code changes.

Local test note

I couldn't confirm the fix with a local test run. In my sandbox, every Jest suite that imports @react-navigation fails to load with "Must use import to load ES Module". That includes suites unrelated to this PR. The same suites passed in this PR's earlier CI run, so the problem is my environment. CI on the new commit will confirm the fix.

view run

melvin-bot · 2026-10-06T10:23:56Z

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Eskalifer1 · 2026-10-06T10:26:03Z

Hi! Seems like i'm second C+ here and it's already approved. If so could you please unassign me here, thank you!

NikkiWines

👍

amyevans · 2026-10-06T10:26:31Z

Yep, sorry for the noise @Eskalifer1!

OSBotify · 2026-10-06T10:30:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-06T10:30:45Z

🚧 NikkiWines has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-06T10:43:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103025.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4050011-fd03f06-33be1e3d5a7ecd14ff2622e9316a052a3bbd385d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4050011-fd03f06-97dbb5f0700942b0bd8dc0d6e5a5d50c729d56d8/index.html

Web 🕸️
https://103025.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-06T22:28:59Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.5.4-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-10-07T19:40:05Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

melvin-bot · 2026-10-07T19:40:05Z

🤖 Payment issue created: #103376

Upgrade metro to 0.84.5 and override image-size to 2.0.4 to fix Depen…

d04ff08

…dabot alerts

MelvinBot requested a review from a team as a code owner October 5, 2026 12:38

MelvinBot assigned amyevans Oct 5, 2026

melvin-bot Bot requested review from daledah and removed request for a team October 5, 2026 12:38

daledah approved these changes Oct 6, 2026

View reviewed changes

melvin-bot Bot requested a review from amyevans October 6, 2026 07:46

melvin-bot Bot changed the title ~~Upgrade metro to 0.84.5 and image-size to 2.0.4 to fix Dependabot alerts~~ [Payment due @daledah] Upgrade metro to 0.84.5 and image-size to 2.0.4 to fix Dependabot alerts Oct 6, 2026

Merge remote-tracking branch 'origin/main' into claude-fixImageSizeVu…

8e58a33

…lnerability Co-authored-by: Amy Evans <amyevans@users.noreply.github.com>

amyevans approved these changes Oct 6, 2026

View reviewed changes

amyevans requested a review from a team October 6, 2026 10:23

melvin-bot Bot requested review from Eskalifer1 and removed request for a team October 6, 2026 10:23

amyevans removed the request for review from Eskalifer1 October 6, 2026 10:26

NikkiWines approved these changes Oct 6, 2026

View reviewed changes

NikkiWines merged commit 4050011 into main Oct 6, 2026
52 of 54 checks passed

NikkiWines deleted the claude-fixImageSizeVulnerability branch October 6, 2026 10:27

OSBotify mentioned this pull request Oct 6, 2026

Deploy Checklist: New Expensify 2026-10-06 #103248

Closed

100 tasks done

melvin-bot Bot mentioned this pull request Oct 7, 2026

[Due for payment 2026-10-14] Payment issue for E/App PR#103025 #103376

Open

Conversation

MelvinBot commented Oct 5, 2026 • edited by amyevans Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 5, 2026

Uh oh!

MelvinBot commented Oct 5, 2026

Uh oh!

daledah commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

daledah commented Oct 6, 2026

Uh oh!

MelvinBot commented Oct 6, 2026

Uh oh!

daledah left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Oct 6, 2026

Uh oh!

MelvinBot commented Oct 6, 2026

Uh oh!

melvin-bot Bot commented Oct 6, 2026

Uh oh!

Eskalifer1 commented Oct 6, 2026

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

amyevans commented Oct 6, 2026

Uh oh!

Uh oh!

OSBotify commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 7, 2026

Uh oh!

melvin-bot Bot commented Oct 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MelvinBot commented Oct 5, 2026 •

edited by amyevans

Loading

daledah commented Oct 6, 2026 •

edited

Loading