Skip to content

Bump Node to 24.19.0 and enforce npm >= 11.10.0 toolchain #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewGable merged 2 commits into from
Sep 2, 2026
Merged

Bump Node to 24.19.0 and enforce npm >= 11.10.0 toolchain #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d35022d
Bump Node to 24.19.0 and enforce npm >= 11.10.0 via devEngines
NicolasBonet Sep 2, 2026
86ef72a
Drop engines in favor of devEngines
NicolasBonet Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
24.11.0
24.19.0
4 changes: 0 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 11 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,16 @@
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^4.15.1"
},
"engines": {
"node": ">=20.10.0",
"npm": ">=10.2.3"
"devEngines": {

@AndrewGable AndrewGable Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two options here:

  1. Continue using engines, as we have historically. We could update it to Node >=24.19.0 and npm >=11.10.0, although it only warns without engine-strict, I think it copies our existing patterns.

  2. Treat this strictly as a development-toolchain requirement. Keep devEngines, but remove engines since the library itself does not require Node 20+. .nvmrc ensures contributors and CI use an npm version that supports devEngines, and CI’s npm install/npm ci will catch mismatches between them.

Option 2 seems more technically accurate and avoids maintaining two different sets of requirements. The remaining caveat is that npm <10.9 ignores devEngines if someone bypasses .nvmrc.

cc @roryabraham for other thoughts.

@roryabraham roryabraham Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 to keeping devEngines and dropping engines

@NicolasBonet NicolasBonet Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with option 2 in 86ef72a — dropped engines from package.json and the lockfile root, kept devEngines.

"runtime": {
"name": "node",
"version": ">=24.19.0",
"onFail": "error"
},
"packageManager": {
"name": "npm",
"version": ">=11.10.0",
"onFail": "error"
}
}
}
Loading