Skip to content

Bump Node to 24.19.0 and enforce npm >= 11.10.0 toolchain - #774

Merged
roryabraham merged 2 commits into
mainfrom
nicolas-node-24-19-devengines
Sep 4, 2026
Merged

roryabraham merged 2 commits into
mainfrom
nicolas-node-24-19-devengines

Conversation

@NicolasBonet

@NicolasBonet NicolasBonet commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Details

Prep for rolling out npm's min-release-age cooldown (https://github.com/Expensify/Expensify/issues/636594). That setting requires npm >= 11.10.0, so this bumps and enforces the toolchain first:

  • .nvmrc: 24.11.0 -> 24.19.0
  • package.json: replace engines with devEngines requiring node >= 24.19.0 / npm >= 11.10.0 (same block as expensify-common). devEngines only applies to contributors, not consumers of the published package, so engines is dropped rather than maintaining two sets of requirements (same call as Bump Node to 24.19.0 and enforce npm >= 11.10.0 toolchain react-fast-pdf#56).
  • example/package.json / package-lock.json: drop the matching engines entries, no dependency changes
  • build-android.yml / build-ios.yml / build-web.yml: add the same setup-node step (reading .nvmrc) that check.yml / lint.yml already use, since these ran npm ci on the runner-default Node

No .npmrc or min-release-age yet — that's a follow-up.

Related Issues

For https://github.com/Expensify/Expensify/issues/678052

Manual Tests

  1. nvm use 24.19.0 && npm ci succeeds, npm run lint and npm run typecheck pass
  2. nvm use 24.11.0 && npm ci fails with EBADDEVENGINES
  3. CI jobs on this PR set up Node from .nvmrc

Linked PRs

N/A

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@NicolasBonet

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@NicolasBonet
NicolasBonet requested a review from a team September 2, 2026 16:20
@NicolasBonet
NicolasBonet marked this pull request as ready for review September 2, 2026 16:20
exfy-clabot Bot added a commit to Expensify/CLA that referenced this pull request Sep 2, 2026
Comment thread package.json
@roryabraham
roryabraham merged commit cbd23cc into main Sep 4, 2026
10 of 12 checks passed
@roryabraham
roryabraham deleted the nicolas-node-24-19-devengines branch September 4, 2026 18:46
@os-botify

os-botify Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Published to npm in 0.1.338 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants