Bump Node to 24.19.0 and enforce npm >= 11.10.0 toolchain - #774
Merged
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
NicolasBonet
marked this pull request as ready for review
September 2, 2026 16:20
roryabraham
reviewed
Sep 2, 2026
roryabraham
approved these changes
Sep 4, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Prep for rolling out npm's
min-release-agecooldown (https://github.com/Expensify/Expensify/issues/636594). That setting requires npm >= 11.10.0, so this bumps and enforces the toolchain first:.nvmrc:24.11.0->24.19.0package.json: replaceengineswithdevEnginesrequiringnode >= 24.19.0/npm >= 11.10.0(same block asexpensify-common).devEnginesonly applies to contributors, not consumers of the published package, soenginesis dropped rather than maintaining two sets of requirements (same call as Bump Node to 24.19.0 and enforce npm >= 11.10.0 toolchain react-fast-pdf#56).example/package.json/package-lock.json: drop the matchingenginesentries, no dependency changesbuild-android.yml/build-ios.yml/build-web.yml: add the samesetup-nodestep (reading.nvmrc) thatcheck.yml/lint.ymlalready use, since these rannpm cion the runner-default NodeNo
.npmrcormin-release-ageyet — that's a follow-up.Related Issues
For https://github.com/Expensify/Expensify/issues/678052
Manual Tests
nvm use 24.19.0 && npm cisucceeds,npm run lintandnpm run typecheckpassnvm use 24.11.0 && npm cifails withEBADDEVENGINES.nvmrcLinked PRs
N/A