Import errno.h in adapter/syscall/ff_socket_ops.c#1088
Open
michaelkiper wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Building
libff_syscall.sofails on certain instances (below spec) becauseadapter/syscall/ff_socket_ops.cuseserrno/EINVALwithout includingerrno.h.Environment
Build error
With this change,
make clean allinadapter/syscall/completes successfully in the environment above.Additional note on ff_so_zone.c
ff_so_zone.calso useserrno(sem_init failure path) without a direct#include <errno.h>. It currently compiles because dpdk 25.11.2 includes it transitively withrte_eal.h/rte_memzone.h. It is left out of this PR to keep the change minimal to the observed build break, but the same one line fix would apply as well if dpdk changes.