Repository navigation
Document and test interpolation tensor layouts - #1092
Open
garth-wells wants to merge 1 commit into
Open
garth-wells wants to merge 1 commit into
garth-wells wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #189.
Basix already exposes per-entity interpolation tensors through
Mand stores the global interpolation weights in a layout that supports a tensor view without copying. Document these interfaces so users can access component and derivative axes directly:(component, point, derivative)column ordering in C++ and Python, including derivative DOFs and the rank-4 view.Mandxin Python and remove the stale C++ claim thatM()only supports custom elements.Extend the existing interpolation test to exercise the documented tensor contraction, including derivative DOFs that were previously skipped. Add checks that per-entity tensors reproduce the appropriate DOFs for built-in Lagrange, Raviart–Thomas, Nédélec and Hermite elements. No public API or storage changes are needed.
Validation: interpolation tests against a Developer build: 584 passed, 8 expected failures; Sphinx HTML build with warnings as errors; Doxygen HTML build (only existing obsolete configuration-tag warnings); Ruff check/format, Gersemi check, clang-format and whitespace checks.