Repository navigation
Remove allocating finite element tabulate overloads - #1093
Open
garth-wells wants to merge 3 commits into
Open
garth-wells wants to merge 3 commits into
garth-wells wants to merge 3 commits into
Conversation
Removing the allocating tabulate overloads breaks DOLFINx main, which calls one of them. Build the DOLFINx integration job against the branch that updates the call site, FEniCS/dolfinx#4656. Revert to main once that pull request has merged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the two
FiniteElement::tabulateoverloads that allocate and return a buffer. C++ callers now usetabulate_shapeto allocate their output and pass it to the existing output-buffer overloads. Update library callers, C++ tests, and demos accordingly.Preserve Python's
tabulateAPI by allocating the result in the nanobind wrapper and transferring ownership through the shared NumPy helper. Add regression coverage for values and derivatives, float32/float64, empty point sets, and result lifetime and independence.This changes the C++ API: callers of the removed overloads must supply output storage.
Validation: Developer builds of the C++ library and Python extension; 10,113 Python tests passed (337 skipped, 23 xfailed); all 22 C++ test cases and all 9 demos passed. Python demos used the Agg backend and writable temporary cache directories. Ruff, gersemi, clang-format, Pyrefly, and
git diff --checkpassed.Closes #311.