Repository navigation
Set the library SOVERSION to major.minor - #1101
Merged
Merged
Conversation
Each 0.x minor release can break the ABI, so a major-only SOVERSION lets the loader pair libraries with an incompatible libbasix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JudYk8UecTQyirGsLsHUN2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JudYk8UecTQyirGsLsHUN2
Contributor
|
Indeed, we were already doing this in the debian package build, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basix 0.x minor releases can break the C++ ABI, but the SOVERSION was only the major version, so every release installed as
libbasix.so.0/libbasix.0.dylib. A library built against one minor release would then load another and fail later with undefined symbols.The SOVERSION is now
major.minor(libbasix.so.0.12,libbasix.0.12.dylib), so a mismatch fails at load time. Patch releases keep the same SOVERSION and must stay ABI compatible. Windows is unaffected.Downstream packaging that names the library file needs a matching update. The DOLFINx wheel workflow's macOS install-name rewrite is one example.
@drew-parsons (Debian), @minrk (conda-forge) and @francesco-ballarin (FEM on Colab/Kaggle) for awareness, since this changes the installed library name.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JudYk8UecTQyirGsLsHUN2