docs: document Bedrock BYOK env var interpolation and region chain#1331
Merged
Conversation
Document the customModels bedrock config on the BYOK overview page,
covering ${VAR} interpolation for awsRegion/awsProfile/bedrockBaseUrl and
the AWS default region-chain fallback shipped in factory-mono #15966
(Linear CL-912).
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
|
Droid finished @nikhil-factory's task —— View job Review summaryClear, useful documentation addition for Bedrock routing and |
abhay-factory
approved these changes
Jul 24, 2026
![factory-droid[bot]](https://avatars.githubusercontent.com/in/358017?s=60&v=4){kind=small}
| { | ||
| "customModels": [ | ||
| { | ||
| "model": "anthropic.claude-sonnet-4-5-20250929-v1:0", |
Contributor
There was a problem hiding this comment.
[P1] Reconcile baseUrl requirement with the Bedrock example
The Bedrock JSON example omits baseUrl, but the Supported Fields table above still marks baseUrl as required. As written, readers who copy/paste either get an invalid config (if baseUrl is actually required in Bedrock mode) or a misleading reference table (if baseUrl is optional/ignored when bedrock is present), so please update either the table or the example to match the real requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the previously-undocumented
customModels[].bedrockconfig on the BYOK overview page, reflecting the feature shipped in factory-mono #15966 (resolves Linear CL-912).Specifically:
bedrockto the Supported Fields table.bedrockobject fields.${VAR_NAME}interpolation forawsRegion,awsProfile, andbedrockBaseUrl(and whyawsAuthRefresh/awsCredentialExportare excluded).AWS_REGION->AWS_DEFAULT_REGION-> profile region) and fail-fast behavior when no region is configured.Notes
Left
changelog/release-notes.mdxuntouched since entries there are tied to specific CLI release versions.