Align Visualized-BGE multimodal attention masks - #1598
Open
zjn20030811 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[CLS, image tokens, text]embedding layoutProblem
encode_mmprepends image tokens after the prompt CLS embedding and removes the original prompt CLS from the remaining text sequence. Its mask was built as[image mask, full prompt mask], shifting every mask entry by one position. As a result, padding could be attended to while valid text or image positions were masked, and mean pooling used the wrong validity positions.The new helper builds
[prompt CLS mask, image mask, prompt remainder mask], exactly matching the sequence passed to the encoder. Existing model weights and APIs are unchanged.Validation
python -m pytest -q tests/test_visual_bge_attention_mask.py(4 passed)python -m compileall -q research/visual_bge/visual_bge/modeling.py