feat(experiments): display rollout on detail page with inline edit#7895
Open
Zaimwa9 wants to merge 3 commits into
Open
feat(experiments): display rollout on detail page with inline edit#7895Zaimwa9 wants to merge 3 commits into
Zaimwa9 wants to merge 3 commits into
Conversation
Rename "Sample Size" to "Rollout" in the wizard. Show rollout percentage in the Variation Split card on the experiment detail page. Add pen icon to toggle inline edit mode with underline inputs for rollout and variation split, plus Save/Cancel controls.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Read rollout from experiment_rollout nested response instead of flat rollout_percentage. Add updateExperimentRollout mutation targeting the dedicated PATCH /rollout/ endpoint. Pass full rollout payload including enabled and feature_state_value on save.
…iment-rollout-display-edit
Contributor
Docker builds report
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Contributor
Visual Regression17 screenshots compared. See report for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Frontend changes to the experiment detail page rollout configuration:
experiment_rolloutresponse)updateExperimentRolloutRTK Query mutation targeting the existingPATCH /experiments/{id}/rollout/endpointExperimentRollouttype to match the backend response shapeHow did you test this code?
/rollout/and the card updates