Skip to content

feat(experiments): display rollout on detail page with inline edit#7895

Open
Zaimwa9 wants to merge 3 commits into
mainfrom
feat/experiment-rollout-display-edit
Open

feat(experiments): display rollout on detail page with inline edit#7895
Zaimwa9 wants to merge 3 commits into
mainfrom
feat/experiment-rollout-display-edit

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Frontend changes to the experiment detail page rollout configuration:

  • Rename "Sample Size" to "Rollout" in the experiment creation wizard
  • Display rollout percentage in the Variation Split card on the experiment detail page (reads from existing experiment_rollout response)
  • Add inline edit mode (pen icon) for rollout and variation split with underline inputs and Save/Cancel controls
  • Add updateExperimentRollout RTK Query mutation targeting the existing PATCH /experiments/{id}/rollout/ endpoint
  • Add ExperimentRollout type to match the backend response shape

How did you test this code?

  1. Open the experiment creation wizard — verify the step is now labelled "Rollout" instead of "Sample Size"
  2. Navigate to an experiment detail page — verify the Variation Split card shows a "Rollout" row with the percentage above the variant rows
  3. Click the pen icon on the Variation Split card — verify inputs switch to underline style for rollout % and each variation %
  4. Edit values and click Save — verify the PATCH call fires to /rollout/ and the card updates
  5. Click Cancel — verify inputs revert to read-only with original values
  6. Verify control percentage auto-calculates and Save is disabled when split exceeds 100%
image image image

Rename "Sample Size" to "Rollout" in the wizard. Show rollout percentage
in the Variation Split card on the experiment detail page. Add pen icon
to toggle inline edit mode with underline inputs for rollout and variation
split, plus Save/Cancel controls.
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jun 26, 2026 2:25pm
flagsmith-frontend-preview Ready Ready Preview, Comment Jun 26, 2026 2:25pm
flagsmith-frontend-staging Ready Ready Preview, Comment Jun 26, 2026 2:25pm

Request Review

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Jun 26, 2026
Read rollout from experiment_rollout nested response instead of flat
rollout_percentage. Add updateExperimentRollout mutation targeting the
dedicated PATCH /rollout/ endpoint. Pass full rollout payload including
enabled and feature_state_value on save.
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jun 26, 2026
@Zaimwa9 Zaimwa9 marked this pull request as ready for review June 26, 2026 14:27
@Zaimwa9 Zaimwa9 requested a review from a team as a code owner June 26, 2026 14:27
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for a team June 26, 2026 14:27
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jun 26, 2026
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7895 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7895 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7895 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7895 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7895 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7895 Finished ✅ Results

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  44.6 seconds
commit  39e9976
info  🔄 Run: #17881 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43 seconds
commit  39e9976
info  🔄 Run: #17881 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  48.9 seconds
commit  39e9976
info  🔄 Run: #17881 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 2 seconds
commit  39e9976
info  🔄 Run: #17881 (attempt 1)

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression

17 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants