feat(Flags): Add remove option to feature settings#7898
Draft
Dexter2099 wants to merge 1 commit into
Draft
Conversation
|
@Dexter2099 is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature settings currently show archive but not removal, which makes archive look like the only way to retire a feature. This adds the existing remove flow to the settings panel so users can delete a feature without returning to the feature list row menu.
Changes
Closes #7896
Validation
npm run test:unit -- --testPathPatterns=FeatureSettingsTab.utils.test.tsnpx eslint --fix web/components/modals/create-feature/index.tsx web/components/modals/create-feature/tabs/FeatureSettingsTab.tsx web/components/modals/create-feature/tabs/FeatureSettingsTab.utils.ts web/components/modals/create-feature/tabs/__tests__/FeatureSettingsTab.utils.test.tsnpx tsc --noEmit --pretty false 2>&1 | Select-String -Pattern 'web/components/modals/create-feature/index.tsx|web/components/modals/create-feature/tabs/FeatureSettingsTab.tsx|web/components/modals/create-feature/tabs/FeatureSettingsTab.utils.ts|FeatureSettingsTab.utils.test.ts'returned no touched-file errors.npm run typecheckis not clean on this checkout due existing unrelated errors, beginning withcommon/constants.ts(435,36)andcommon/hooks/useCollapsibleHeight.ts(36,15).Review effort: 2/5