Apply real, double precision and boolean column defaults when creating a table - #8794
Merged
Merged
Conversation
…g a table The Postgres drivers read the default for these column types from the SQL string being built instead of the column definition. A real or double precision default failed the create with DEFAULT NaN, and a boolean default was always false.
Steve-Mcl
reviewed
Oct 5, 2026
Steve-Mcl
left a comment
Steve-Mcl
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Awaiting tests before merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8794 +/- ##
=======================================
Coverage ? 78.37%
=======================================
Files ? 474
Lines ? 25639
Branches ? 6827
=======================================
Hits ? 20095
Misses ? 5544
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andypalmi
enabled auto-merge (squash)
October 6, 2026 08:28
Contributor
|
@Steve-Mcl did you mean to mark this as approved not just leave a comment? |
hardillb
approved these changes
Oct 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8793
Both Postgres drivers built the
DEFAULTclause forreal,double precisionandbooleancolumns fromcolumn.default, wherecolumnis the SQL string being built. They now readcol.defaultlike the other types.realordouble precisiondefault no longer fails the create with "cannot use column reference in DEFAULT expression".booleandefault oftrueis no longer created asfalse.Each driver spec has a new test for these three types, which fails without the fix.