Fix/hubspot meetings embed - #5906
Merged
Merged
Conversation
✅ Deploy Preview for flowfuse-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…c prop, import site.json in contact-us
Yndira-E
requested review from
ZJvandeWeg and
dimitrieh
and removed request for
dimitrieh
October 5, 2026 10:37
Yndira-E
marked this pull request as ready for review
October 5, 2026 10:37
2 of 5 tasks
dimitrieh
approved these changes
Oct 5, 2026
dimitrieh
left a comment
dimitrieh
left a comment
Contributor
There was a problem hiding this comment.
Yndira, approving this one. Checking the stored consent on mount fixes the calendar not showing after a reload.
I opened a follow-up for you to consider: #5910. It creates a new iframe on each mount rather than re-attaching the earlier one, keeps the fallback up until the iframe is actually there, and removes the embed when analytics consent is withdrawn. The trade-off is the one you avoided here: HubSpot's leftover listeners throw a console error after a client-side revisit, though the calendar itself works. If you agree with the approach, merge it after this one.
dimitrieh
approved these changes
Oct 5, 2026
Builds on the consent check from the previous commits and replaces the retained-iframe approach: - Each mount calls hbspt.meetings.create() for its own container (unique id from useId), so a page reached by client-side navigation gets a fresh, correctly addressed iframe without rewriting HubSpot's src by hand. This also keeps the current HubSpot utk, and lets two instances coexist. - The fallback stays until an iframe is actually in the container, watched with a MutationObserver. HubSpot inserts it after create() returns, so setting embedded on script load emptied the slot early, and a blocked or stubbed script left neither calendar nor fallback. - The script 'load' listener is removed on unmount, so a stale instance can no longer call create() on another page. - Withdrawing analytics consent removes the embed. - The VPP blog post linked the retired round-robin calendar through a mangled URL; it now links /book-demo/. Known cost: HubSpot's script adds two window message listeners per iframe and never removes them. After a client-side revisit, the old iframe's consent listener throws "Cannot read properties of null (reading 'postMessage')" in HubSpot's own code when the new iframe loads. The calendar is unaffected.
Contributor
Author
|
Thanks @dimitrieh! I've implemented your suggestion, plus a couple of things on top. Could you take another look and merge if it's all OK? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the embedded HubSpot calendar (
/book-demo,/landing/tulip) not showing up in some cases, and keeps it behind analytics consent:cc:onConsent/cc:onChange, instead of thewindow._ffLoadMeetingsglobal (removed fromcookieconsent-config.js).site.meetings.salesRoundRobin./landing/tulipmoves to the shared calendar on purpose, and the VPP blog post links/book-demo/instead of the retired calendar.Known cost: HubSpot's script adds two window listeners per iframe and never removes them, so each client-side revisit adds two more and the old iframe's listener throws a TypeError in HubSpot's code. The calendar is unaffected.
Supersedes #5910.
Follow-ups
Related Issue(s)
Checklist