Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The CLI currently passes every discovered package-local
build.yamlas an explicit build file. If it configures only another builder, FlutterGen generates the requested assets and exits successfully but logsSEVERE: ... does not contain valid options. This also happens for workspace members.Let the core configuration loader handle implicit discovery and look beside the selected pubspec. It only uses a discovered file when it contains FlutterGen options. Explicit
--buildinputs keep their existing diagnostics and precedence, and valid package-local options still work when--configpoints outside the working directory.Related to #702. The current build_runner implementation already consumes
BuilderOptionsdirectly; I reproduced and fixed the remaining CLI path on current main.Type of change
Validation
On macOS arm64, Flutter 3.44.2 / Dart 3.12.2:
dart run melos test: 106 passed across the command, core, runner and Flutter example suites. Unmodified baseline: 102 passed.dart run melos test:xml-matrix: 90 passed with xml 6.x and 90 with xml 7.x.dart run melos analyze: all six packages passed.git diff --check: passed.Before the production change, the two CLI regressions emitted SEVERE and the new package-local core discovery regression selected the wrong output directory. After the change they pass. The existing fallback test now writes its fixture beside the pubspec and verifies a freshly generated output path; it also fails on the original core source. A control verifies that an explicitly selected build file without options still reports SEVERE.
Windows/Linux CI and native application builds were not run locally. The full host test suite, including the existing build_runner workspace integration tests and Flutter widget tests, was run without adding skips or changing timeouts.
Checklist
melos testcompleted.AI assistance: this patch and its tests were developed and reviewed with OpenAI Codex. The validation results above were run locally; upstream review and CI remain pending.