Repository navigation
test(serve): pin CVE order and oversize status; warn on non-loopback (#33) - #34
Merged
Merged
Conversation
…33) Co-authored-by: hsinatfootprintai <149764663+hsinatfootprintai@users.noreply.github.com>
5 tasks
hsinatfootprintai
added a commit
that referenced
this pull request
Oct 27, 2026
…sue (#38) PR #34 carried "Closes #33" and was auto-merged by the automerge workflow, but issue #33 stayed open. The workflow's permissions block grants only contents and pull-requests, so the issues scope is none for the token that performs the merge. A person-merged PR (#35) closed its issue normally. Add issues: write. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #33:
[S9b] Web follow-up: pin CVE ranking order, document serve, exact oversize status, warn on non-loop…Closes #33
The line above closes the issue when this pull request is merged. The agent reports 4 of 5 checklist items as met (see Acceptance below). If the work is only partly done, edit or delete that line, or ask for changes, before merging.
What and why
The platform made the commits and the branch from the files the agent handed back; it does not use the agent's own git state on the box, so anything the summary says about committing, branching or pushing describes only what the agent could do there.
The agent's summary, quoted:
The agent's decisions, and where it departed from the issue or the design, quoted:
Changes
README.md— 56 linescmd/touchstone/main.go— 87 linescmd/touchstone/serve.go— 119 linescmd/touchstone/serve_test.go— 191 linesinternal/server/server_test.go— 100 linesweb/src/components/report-view.test.tsx— 154 lines6 file(s) in all.
Acceptance, from the issue
The ranking test fails if the component sorts or reverses the CVE list.— the agent says:Test uses a non-sorted, non-reversed CVE order and asserts DOM order; not run here.`README.md` documents `--addr`, `TOUCHSTONE_ADDR` and the `make web-build` order.— the agent says:README section documents --addr, TOUCHSTONE_ADDR and the make web-build order.The oversized-body test asserts the exact status and a zero service-call count.— the agent says:Asserts exact 400 and zero service calls via a counting wrapper; not run here.A non-loopback address prints a warning to stderr; a loopback address prints nothing; both are tested.— the agent says:serve warns on stderr for non-loopback; helper table and serve-level tests added; not run here.`go vet ./...`, `go test ./...`, `npx tsc --noEmit` and `npx vitest run` pass.— the agent says:go vet, go test, npx tsc and npx vitest were not run; execution was refused.The items are the issue's own; each status is the agent's report, which the platform has not checked.
Checks
Review this like any other change. The agent ran on the member's own machine from the text of the issue; the platform has not built or tested it. CI results appear on this pull request.
not_runHow this pull request was made
Opened by the platform from a coding agent's run on a member's box (run
dc0bbf20). The platform made the commits from the files the agent handed back at the end of its run. Nothing is merged automatically.