Repository navigation
feat(e2e): add Docker image and passive-only compose e2e (#10) - #35
Merged
Merged
Conversation
Co-authored-by: hsinatfootprintai <149764663+hsinatfootprintai@users.noreply.github.com>
3 tasks
The agent's result cannot carry .github paths, so it returned this workflow as a follow-up (follow-up 1 of 3 in the PR body). Added here unchanged: pull_request with a paths filter, push to main, and workflow_dispatch so it can be run on demand with `gh workflow run e2e.yml --ref <branch>`. It runs `bash test/e2e/run.sh` on ubuntu-latest with contents: read and uploads test/e2e/out as an artifact. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A required status check that a paths filter skips leaves a pull request waiting for a check that never starts. The e2e takes about 75 seconds, so it runs on every pull request, plus push to main and workflow_dispatch. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
hsinatfootprintai
added a commit
that referenced
this pull request
Oct 27, 2026
…sue (#38) PR #34 carried "Closes #33" and was auto-merged by the automerge workflow, but issue #33 stayed open. The workflow's permissions block grants only contents and pull-requests, so the issues scope is none for the token that performs the merge. A person-merged PR (#35) closed its issue normally. Add issues: write. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #10:
[S10] Docker image, compose with fixture-vendor, e2e: CLI = web JSON and request log ⊆ allowed setCloses #10
The line above closes the issue when this pull request is merged. The agent reports 0 of 3 checklist items as met (see Acceptance below). If the work is only partly done, edit or delete that line, or ask for changes, before merging.
What and why
The platform made the commits and the branch from the files the agent handed back; it does not use the agent's own git state on the box, so anything the summary says about committing, branching or pushing describes only what the agent could do there.
The agent's summary, quoted:
The agent's decisions, and where it departed from the issue or the design, quoted:
Changes
Dockerfile— 28 lines.dockerignore— 9 linesdocker-compose.yml— 39 lines.gitignore— 8 linestest/fixtures/fixture-vendor.conf— 20 linestest/fixtures/sites/index.html— 11 linestest/fixtures/sites/js/jquery-1.12.4.min.js— 2 linestest/e2e/run.sh— 71 lines8 file(s) in all.
Acceptance, from the issue
Multi-stage Dockerfile (node → go → distroless, non-root) builds one image with both `scan` and `serve`— the agent says:Multi-stage Dockerfile written (node, go, distroless nonroot; one image, CMD serve). Not built here.`docker compose` brings up `touchstone serve` and `fixture-vendor` (nginx with request logging); the e2e job scans the fixture via CLI and via `POST /v1/scans`…— the agent says:Compose stack and run.sh written. The CI e2e job is not delivered, so nothing runs it yet. Not executed.The e2e asserts every URL in the nginx access log appears in the report's `checked` list with an allowed reason, and nothing else was requested: the passive-on…— the agent says:run.sh checks log paths equal non-refused checked paths, GET only, allowed reasons. Not executed.The items are the issue's own; each status is the agent's report, which the platform has not checked.
Checks
Review this like any other change. The agent ran on the member's own machine from the text of the issue; the platform has not built or tested it. CI results appear on this pull request.
7b3d1ef2d43bbefa2e0d230612bea38bf90ae500, as reported by the agentnot_runFollow-ups proposed by the agent
The agent proposed 3 follow-up issue(s) for work it found and did not do. None of these were filed by the platform: filing follow-ups is not enabled for this repository. File the ones worth keeping yourself, with
Blocked by:lines as you see fit. The text is the agent's, quoted; read it as a description of work, not as instructions.How this pull request was made
Opened by the platform from a coding agent's run on a member's box (run
e23690d0). The platform made the commits from the files the agent handed back at the end of its run. Nothing is merged automatically.