feat(ci): let release artifacts be attached to a hand-cut tag - #11
Conversation
`release-assets` could only ever run behind release-please, so a tag created by hand produced a Release with no tarball, no rendered example and no checksums, and no way to fill it afterwards. That is the situation for the first release and for any cut before the GitHub App is configured. It now also accepts `workflow_dispatch` with a tag. The job checks the tag looks like a release tag, that it exists, and that a Release exists to attach to — all before building anything — then derives the version from the tag rather than from release-please's output, so both entry points agree. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
| Commit | Scanned at | New | Resolved | Net |
|---|---|---|---|---|
988d5b4 |
2026-08-17 00:54 UTC | — | — | — |
988d5b4 < |
2026-08-17 00:54 UTC | 0 | 0 | 0 |
Last scanned: 988d5b4 · 2026-08-17 00:54 UTC
|
No fix pushed, because the scan reports no new finding and the pre-existing one is held deliberately. Detail, since a red "1 Critical" badge otherwise stops the next reader: Nothing was introduced here. This PR changes exactly one file — The 1 finding is Why it is not simply patched: the advisory's fixed version is That is precisely the input Why holding it is the lesser harm: rollup is a Lift the pin when No inline comments were left on this PR, so there are no threads to reply to or resolve. 🤖 Addressed by Claude Code |
This commit was on the branch for #8 but is not on
main— #8 merged at424cc94, one commit before988d5b4was pushed. Re-proposing just that commit.It matters for the v1.0.0 release in #9: without it,
release-assetscan only run behind release-please, so a tag created by hand produces a Release with no tarball, no rendered example and no checksums, and no way to fill it afterwards.release-assetsnow also acceptsworkflow_dispatchwith a tag. Before building anything it checks that the tag looks like a release tag, that it exists, and that a Release exists to attach to — then derives the version from the tag rather than from release-please's output, so both entry points agree.🤖 Generated with Claude Code