fix(ci): gate exclusion for app-build + QF1008 lint fix - #270
Merged
Conversation
… embedded selector Two CI-Go legs have been red on main since the Tauri app (#267) and TUI polish (#268) landed: 1. Single-implementation gate: app-build.yml legitimately invokes pnpm (Tauri 2 webview UI, issue #181 / PRD §20.4 decision) — the gate's Go-only rule covers the DevAgent core, so exclude that one workflow's lines from the grep instead of weakening the gate itself. 2. staticcheck QF1008: polish_contract_test.go:323 used the embedded bufEnv selector; winchEnv promotes cols, so env.cols is identical. The TestApplyKeysApproveSheet CI-only failure (passes locally 30+ runs on the same SHA) is filed separately with full analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.github/workflows/app-build.ymllines (Tauri UI stack is TS by design, §20.4/Cross-platform desktop control app — Tauri 2 tray + dashboard (FR-UI-01..09) #181); gate grep itself unchanged and still fails on any other workflow invoking Node.polish_contract_test.go:env.bufEnv.cols→env.cols(staticcheck QF1008; winchEnv embeds bufEnv).Evidence
grep -rnE '(npm|npx|tsx|node) ' .github/workflows/*.yml | grep -v '^\.github/workflows/app-build.yml:'→ empty → gate passes; any other workflow still trips it.go test ./internal/tui/ -count=1green ×3, gofmt/vet clean.Partially unblocks CI-Go/Release on main (windows build already fixed by #269). The remaining
TestApplyKeysApproveSheetCI-only failure is documented in the follow-up issue.