fix(config): inject the gh token resolver seam — kills the 5s exec-timeout flakes (#262) - #272
Merged
Conversation
…meout flakes (#262) ghAuthToken becomes a package-level seam (var ghAuthToken = ghAuthTokenExec); tests stub it instead of shimming PATH with a fake gh binary, so the 5s exec.CommandContext timeout can no longer fire under machine load (full-suite package parallelism was spawning the fake gh late). Trimming moves into resolveGithubToken; real-exec coverage retained for gh-absent and non-zero exit paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ghAuthTokenbecomes a package-level seam (var ghAuthToken = ghAuthTokenExec); tests stub it instead of shimmingPATHwith a fake gh binary, so the 5sexec.CommandContexttimeout can no longer fire under machine load (full-suite package parallelism delayed fake-gh startup past 5s →TestResolveGithubToken*flaked — exactly issue test(config): fake-gh token tests hit the 5s exec timeout under load — harden or inject the resolver #262's report).resolveGithubToken(TrimSpace on the seam result); real-exec coverage retained for gh-absent and non-zero-exit paths.Evidence
go test ./internal/config/ ./internal/cli/ -count=1green in the worktree (also green under load).Closes #262