fix: Limit GPT headerSize to the sector size#84
Merged
Conversation
archigup
previously approved these changes
Jun 23, 2026
archigup
left a comment
archigup
left a comment
Member
There was a problem hiding this comment.
Commit history could be cleaned up so we'd be able to rebase this onto main
Member
Author
|
I'll have the commit history cleanup out shortly. Merging in #83 once the checks pass due to my rebase. |
GPT sector size is unlimited however the use of 16-bit integers limit a practical change to supporting 65KB sectors. Luckily the most common sector size is 4096. The library should be good for some time. Without this change the code would blindly trust the given header size value even if the sector couldn't possibly be that size.
kstribrnAmzn
dismissed
archigup’s stale review
The merge-base changed after approval.
kstribrnAmzn
force-pushed
the
gptSectorSize
branch
from
7b8e871 to
9c04d2c
Compare
archigup
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GPT sector size is unlimited however the use
of 16-bit integers limit a practical change
to supporting 4096 byte sectors. Luckily this
is a common sector size.
Without this change the code would blindly
trust the given header size value even if
the sector couldn't possibly be that size.
Thanks @Eun0us for help in identifying this miss.
Test Steps
Added unit tests
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.