Prepare the 1.18 release - #52
Open
coraislovely-code wants to merge 4 commits into
Open
Conversation
The Flash comic display path went with PR Frumph#49; four msgids naming it stayed behind in the translation template, along with the .flash_file rule that styled the URL input the same PR removed. Nothing in css/ or js/ mentions flash now. lang/comic-easel-en_US.mo is left alone: it compiles a single header entry and no translations, so it carries none of these strings and recompiling it would only churn a file that has never had anything to say. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The release zip is a git archive of the tag, so the test suite, the CI workflows and the composer/phpcs/phpunit configuration were shipping to every site that installed the plugin. export-ignore keeps them in the repository and out of the archive. .wordpress-org is listed ahead of its existence: listing assets belong in the SVN assets directory rather than the plugin zip, and the entry means the directory is already excluded when they arrive. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The save handler took a value that was new against an empty stored one to mean no row existed, and reached for add_post_meta() with $unique set. When a row does exist holding the empty string, that add is refused and nothing is written: the author's text disappears on save with no error. Empty rows are ordinary -- the comic post type supports custom-fields, and importers and wp-cli leave them behind too. update_post_meta() creates the row when it is absent, so the two branches are one. The delete-when-blank branch is untouched. The add_post_meta() stub now models the unique refusal, which is what lets a test tell an absent row from an empty one: get_post_meta() reports '' for both. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Version 1.18 in the plugin header and the stable tag, with the changelog and an
upgrade notice for the release. Tested up to 7.0 is claimed on the strength of
a manual pass over the recipes in tests/manual on WordPress 7.0.4 and PHP 8.5.
Domain Path names the directory holding the shipped translations, which
WordPress needs to find them for a plugin whose files do not sit under a
matching path. The readme gains the Screenshots section that gives the listing
image its caption.
ceo_pluginfo('version') still answered 1.15 -- it was missed when the header was
corrected for 1.17 -- and now matches the header. It reaches the front end
through the generator meta tag and the update-check user agent.
The screenshot moves to .wordpress-org/, the directory the listing assets are
uploaded from; wordpress.org serves them out of SVN rather than the plugin zip,
so shipping it only added 133 KB to every download. No icon or banner yet.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release mechanics for 1.18, ahead of the wordpress.org re-listing request:
Tested up to: 7.0, via full manual-recipe pass on WordPress 7.0.4 / PHP 8.5 / MySQL: activation DDL, chapter-ordered archives, calendar queries, widgets, buycomic refusals and admin write paths, with an empty debug.log throughoutDomain Path: /langheader, a== Screenshots ==section, and the screenshot relocated to.wordpress-org/(listing assets are served from SVN, not the shipped zip).gitattributesexport-ignore entries so release archives contain only runtime files🤖 Generated with Claude Code