feat(design-system): expand the foundational UI component library - #2526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActionItemFieldIconButtonInputKeyHintPageHeaderSearchFieldButtonwithprimaryandtextpresentation variants while preserving the existing default behavior.ActionItemcompositions do not overlap.Fixes #
Type and Areas
Type:
Feature / UI/UX / regression fix / test
Areas:
Design system UI package, Design Lab, component registry, component documentation and previews
Motivation / Impact
This expands the new component library with reusable action, form, keyboard-hint, search, and page-heading contracts. It provides a stronger foundation for gradually replacing legacy or locally implemented UI with consistent design-system components.
The new APIs keep semantics, presentation, state, and composition independently configurable. Existing
Buttonbehavior remains compatible because its default variant is unchanged.There is no direct end-user change outside Design Lab in this PR because existing application call sites are not migrated yet. Developers can begin adopting the new components incrementally.
Verification
pnpm --filter @bitfun/design-lab testpnpm run design-system:checkActionItempreserves spacing between its leading content, label, shortcut, and trailing actions.Reviewer Notes
@bitfun/ui.Buttonvariant union is additive; existingoutlineandfillusages and the defaultoutlinebehavior are preserved.Checklist