fix(sentry): the daemon's mapping-cache allocation flag resets per capture - #65
Merged
Conversation
…pture sentry[bot] on getsentry/sentry-native#2053: `g_vma_alloc_failed` was never reset in `capture_modules_from_proc_maps`, so one allocation failure would disable the ARM32 frame-pointer walk for every later crash the same daemon instance handled. Reset it with the other per-capture state. Mirrors the same one-line change on the upstream PR. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the one-line fix from sentry[bot]'s comment on getsentry/sentry-native#2053 into
webos-arm32.patch:g_vma_alloc_failedis reset at the top ofcapture_modules_from_proc_maps, so an allocation failure disables the ARM32 frame-pointer walk for that capture only. Patch re-applied and the handler cross-built; no behaviour change on a healthy capture, so no device run.🤖 Generated with Claude Code