Repository navigation
Conversation
…eps.tsv Bead: pgp-5bja.14
…every plugin hook The frames are Live.state() with every bin/owngenome_live_*.py plugin loaded, read while the invented weblog is stored message by message. The test is red when a build drops one plugin's state hook. Bead: pgp-5bja.14
Bead: pgp-5bja.14
… workflow Bead: pgp-5bja.14
… real site Bead: pgp-5bja.14
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Owner
Author
|
@coderabbitai review |
Action not completed
|
…the docs publish The retake job stops before any picture while a report section has no demo input; the live picture needs no container and should not wait on it. Bead: pgp-5bja.14
The picture is the artifact of the live-picture job of Demo pictures. Bead: pgp-5bja.14
…wait_for_function can poll
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The live site only shows something once you have your own run going behind a password. Someone who wants to see what it does first has nothing to open.
Fix
The docs site now carries a demo at https://geiserx.github.io/OwnGenome/demo/. It is the live page in replay mode on DEMO-001, the invented sample of the docs pictures.
tests/demo/make_demo_events.pywrites an invented weblog of a DEMO-001 run fromassets/steps.tsv: every step with processes, in upstream order, with one retried task and one task near its memory request. The fixture istests/fixtures/live/demo-001.weblog.jsonl.tests/demo/build_live_demo.pystores those messages one by one in the realLivestore, with everybin/owngenome_live_*.pyplugin loaded, and keepsLive.state()as a frame each time a step ends or a plugin's state changes. The page,live.jsand the plugin scripts areassets/live/unchanged. Charts, search, run health, the database re-check and the family page all work. The viewer links lead to a page that says the viewer is not in the demo.docs.ymlbuilds the demo intosite/demoafter the strict MkDocs build, on pull requests too, and the push paths now include the code the demo is built from:assets/**(the page, the plugin scripts and the gene and rule tablesrender_report.pyreads),bin/**,tests/demo/**andtests/fixtures/live/**.render_pictures.py --only livetakesdocs/images/demo-live-site.pngfrom the demo as the docs publish it. A newlive-picturejob in Demo pictures runs it and checks the PNG chunks. It needs no container, so it does not wait on the retake job. The picture's browser bypasses the page policy: underscript-src 'self'Playwright'swait_for_functioncannot poll, and the page's own scripts are all'self', so the picture does not change.docs/live-site.mdhas a "Try the demo" section with that picture;docs/index.mdand the README link the demo.Decisions, each the smallest change that keeps main true:
owngenome_recheck.affected_steps.frame-ancestors, which a meta tag cannot set). The site's absolute/runs/and/family/links in plugin state become relative.No output, option or config key of the pipeline changes. The PR touches nothing the e2e cases exercise (no
scripts/,modules/,workflows/,bin/,conf/,assets/ortests/e2e/file) and adds no e2e case.When the live viewer lands, its plugin script and state hook join the demo with no edit here. The test then asks that hook for a value on the demo run, so that merge must be checked against
tests/test_live_demo.py.How it was checked
tests/test_live_demo.py(run by the unit-tests job): the weblog fixture matches its generator; every registered hook has a value; the frames follow the run; the invented machine is measured and no build path leaks; every link resolves; every page carries the policy and loads nothing from outside; and a headless Chrome on a static server with no policy header checks replay, charts, search, re-check, run health, family page, viewer page and zero policy violations.demo-live-pictureartifact of https://github.com/GeiserX/OwnGenome/actions/runs/41849289931 (job live-picture green, chunk check passed).EvalError ... violates the following Content Security Policy directive): https://github.com/GeiserX/OwnGenome/actions/runs/41868569753 With the policy bypassed for the picture it is green: https://github.com/GeiserX/OwnGenome/actions/runs/41873271939retakejob of Demo pictures is red for a reason this PR does not touch:make_demo_sample.py checkstops on thecallabilitysection, which no demo input feeds since the gene callability change. A pull request built on main fails the same way: https://github.com/GeiserX/OwnGenome/actions/runs/41836158825 That file is outside this PR. The live picture now runs in its own job for that reason.Bead: pgp-5bja.14