Skip to content

bugfix: exclude observers from roster type computation #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoKeRZH429 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix: exclude observers from roster type computation #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion GenOnlineService/Database/Database.MatchHistory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,10 @@ public static async Task<ulong> CreatePlaceholderMatchHistory(
jsonSlots[member.SlotIndex] = JsonSerializer.Serialize(model);

// Observers are not active players
if (model.side != Constants.OBSERVER_SIDE_VALUE)
// This function runs at the start of a match, before observers are assigned
// their actual side value. Observers have PLAYERTEMPLATE_RANDOM (-2) at this
// point, so use that value to identify and exclude them.
if (model.side != -2)
{
if (playersPerTeam.ContainsKey(model.team))
{
Expand Down
Loading