Skip to content

fix: iOS boolean conversion never parsed false - #59

Merged
santhoshvai merged 1 commit into
masterfrom
ios-boolean-conversion--fix
Aug 6, 2026
Merged

fix: iOS boolean conversion never parsed false#59
santhoshvai merged 1 commit into
masterfrom
ios-boolean-conversion--fix

Conversation

@santhoshvai

@santhoshvai santhoshvai commented Aug 5, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Corrected conversion of WebRTC constraint values to "true" or "false", ensuring non-boolean inputs are interpreted based on their actual boolean value.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1bff96ea-f2c5-4d1d-908b-369e99ce8cb3

📥 Commits

Reviewing files that changed from the base of the PR and between 80c9ea7 and 8c8e33e.

📒 Files selected for processing (1)
  • ios/RCTWebRTC/WebRTCModule+RTCMediaStream.m

📝 Walkthrough

Walkthrough

Changes

Boolean constraint conversion

Layer / File(s) Summary
Use boolValue for conversion
ios/RCTWebRTC/WebRTCModule+RTCMediaStream.m
convertBoolToString: now converts values based on [value boolValue] instead of Objective-C object-reference truthiness.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: greenfrvr

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the iOS boolean conversion bug fixed by the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ios-boolean-conversion--fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@santhoshvai
santhoshvai merged commit a0dac58 into master Aug 6, 2026
5 of 6 checks passed
@santhoshvai
santhoshvai deleted the ios-boolean-conversion--fix branch August 6, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants