Repository navigation
chore: stream-chat rc.31 compatibility - #3919
Merged
Merged
Conversation
Contributor
SDK Size
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets:
🎯 Goal
Bumps
stream-chatto10.0.0-rc.31and removes the SDK code it makes redundant. rc.31 includes GetStream/stream-chat-js#1982, GetStream/stream-chat-js#1985, GetStream/stream-chat-js#1986 and GetStream/stream-chat-js#1987.328ecfb7esetupCommandUIMiddlewares01671f45bf34a0b01cstream-chatto^10.0.0-rc.31🛠 Implementation details
REACT-1184 - remove
setupCommandUIMiddlewaresCommit:
328ecfb7eGetStream/stream-chat-js#1985 installs the four command middlewares in every composer by default: the active command guard and the command string extraction around the commands middleware, and the command injection after attachments, for messages and for drafts. Those are the same middlewares, with the same ids and positions, that
setupCommandUIMiddlewaresinserted, so the helper has nothing left to do and is removed. SampleApp no longer calls it.This is a breaking change. Apps that call
setupCommandUIMiddlewaresdelete the call. Apps that never called it now get the command behaviour too: typing/giphy catsmakesgiphythe active command and leavescatsin the input.ai-docs/ai-migration-v9-to-v10.mdandai-docs/v10-breaking-changes.mdare updated, and the note about the REACT-1489 fix to this helper is dropped since the helper is gone.REACT-1400 - pinned-message search
Commit:
01671f45bMessageSearchSourcematched message text by exact equality, soChannelPinnedMessageListProviderreplaced that filter with its owntext: { $q }. GetStream/stream-chat-js#1987 makes the defaulttext: { $autocomplete }, so the override is removed. Pinned-message search now matches by word prefix: "lun" finds "Lunch tomorrow?". An empty query still lists every pinned message.Bump
stream-chatto10.0.0-rc.31Commit:
f34a0b01cThe SDK and the four example apps move to
^10.0.0-rc.31. Besides the two changes above, it brings:ChannelManager.Neither needs a change here.
🎨 UI Changes
None.
🧪 Testing
/giphy catsshows the GIPHY chip withcatsin the input, and sending it shows the Giphy preview. Picking Giphy from the commands menu and typingdogsdoes the same.yarn typecheck,yarn lintandyarn buildpass.☑️ Checklist
developbranch