chore: pass OpenAPI generator config via --opt flags by gpunto · Pull Request #1743 · GetStream/stream-video-android

gpunto · 2026-07-10T10:21:47Z

Goal

The backend Kotlin OpenAPI generator was refactored so it takes its configuration through the generic --opt key=value flag (the Configurable interface master already uses for Swift) instead of a set of bespoke named flags. This keeps the shared chat generator command free of language-specific flags. This PR updates the video client generation script to match the new interface.

The chat-side generator changes are merged to GetStream/chat master (#14637), so this PR is unblocked. The script clones master (REFERENCE_VALUE=master).

Implementation

Convert the generate-client invocation to --opt key=value form.
The SDK selector is passed as --opt android-sdk=<video|feeds|chat> (kebab-case; the generator validates it).
Drop --model-dir: the generator hardcodes the models directory, so the flag was a no-op. Removed the flag, its MODEL_DIR variable, and its argument handling.
classes-to-skip is now space-separated — the --opt slice flag splits comma-separated values, so a comma list would be mangled.
Point REFERENCE_VALUE at master.

🎨 UI Changes

N/A — build/tooling script only.

Testing

Ran the full script end-to-end against current master: it clones master, builds chat-manager, generates the video spec, and generates the Kotlin client — exit 0, valid output (apis/ + models/ + infrastructure/). Output matches the previous generator for the same spec; this is a tooling/invocation change with no generator behavior change.

☑️Contributor Checklist

General

PR targets the develop branch
Assigned a person / code owner group
Thread with the PR link started in a respective Slack channel

Code & documentation

Script verified end-to-end against current master

github-actions · 2026-07-10T10:22:00Z

PR checklist ✅

All required conditions are satisfied:

Title length is OK (or ignored by label).
At least one pr: label exists.
Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

github-actions · 2026-07-10T10:29:24Z

SDK Size Comparison 📏

SDK	Before	After	Status
stream-video-android-core	12.27 MB	12.27 MB	🟢
stream-video-android-ui-xml	5.68 MB	5.68 MB	🟢
stream-video-android-ui-compose	6.20 MB	6.20 MB	🟢

github-actions · 2026-07-27T08:08:07Z

This pull request has been automatically marked as stale because it has been inactive for 14 days. It will be closed in 7 days if no further activity occurs.

The chat-side Kotlin generator now takes its configuration through the generic `--opt key=value` flag (via the Configurable interface) instead of bespoke named flags. Update the generation script accordingly: - Convert the generate-client invocation to `--opt key=value` form. - Drop `--model-dir` (the generator hardcodes the models directory; the flag was a no-op) and its now-unused MODEL_DIR variable / argument. - classes-to-skip is space-separated (the --opt slice flag splits comma lists). - Point REFERENCE_VALUE at `master`, since the generator changes land there. Generated output is unchanged (byte-identical vs the previous generator).

The backend generator's SDK option was renamed androidSdk -> android-sdk during review before landing on master. Update the invocation to match, otherwise generate-client fails with `kotlin: unknown option "androidSdk"`.

coderabbitai · 2026-07-28T07:41:43Z

Walkthrough

The OpenAPI generation script updates its defaults, removes model-directory CLI configuration, and changes client generator arguments to --opt key=value assignments with revised option names.

Changes

OpenAPI generation workflow

Layer / File(s)	Summary
Generation defaults and argument parsing `generate_openapi_v2.sh`	Updates default generation values, changes the classes-to-skip format, and removes support for the `--model-dir=` argument.
Client generation option wiring `generate_openapi_v2.sh`	Passes client generation settings through `--opt key=value` arguments, updates option names, and stops forwarding `model-dir`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

GetStream/stream-video-android#1713: Updates the same OpenAPI client generation workflow and generator argument wiring.

Suggested reviewers: aleksandar-apostolov, andremion

Poem

A rabbit hops through scripts so neat,
With options lined in key=value feet.
“Master” guides the generator’s way,
While model-dir quietly fades away.
The client blooms from specs anew—
Hop, hop, generated just for you!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: passing OpenAPI generator config via --opt flags.
Description check	✅ Passed	The description covers the required Goal, Implementation, UI Changes, and Testing sections, with only non-critical checklist/gif items missing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/openapi-generation-opt-flags

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@generate_openapi_v2.sh`:
- Around line 191-198: The generate_openapi_v2.sh option handling must remain
aligned with scripts/open-api-code-gen.gradle.kts: restore parsing and
forwarding of the model-dir argument, or remove the Gradle caller’s modelsDir
configuration and argument if model directories are intentionally retired.
Ensure configured model directories are neither silently ignored nor rejected
unexpectedly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 855af949-c3bf-482d-bd59-1125a3b408cf

📥 Commits

Reviewing files that changed from the base of the PR and between 8fbaea4 and c16aff8.

📒 Files selected for processing (1)

generate_openapi_v2.sh

generate_openapi_v2.sh no longer accepts --model-dir (the backend generator hardcodes the models directory and never honored the flag), so the Gradle caller passing it would fail with "Unknown argument". Remove the argument and the now-unused modelsDir property.

The Gradle task's default refValue still pointed at the merged (now-deleted) feature branch, so `generateOpenApiClient` would fail at `git clone --branch`. Default to master, matching the script's own default and the intended source.

sonarqubecloud · 2026-07-28T08:49:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rahul-lohra

lgtm

stream-public-bot · 2026-08-05T12:09:55Z

🚀 Available in v1.30.0

gpunto added the pr:internal Internal or infra-only changes label Jul 10, 2026

github-actions Bot added the Stale label Jul 27, 2026

gpunto removed the Stale label Jul 28, 2026

gpunto marked this pull request as ready for review July 28, 2026 07:34

gpunto requested a review from a team as a code owner July 28, 2026 07:34

gpunto added 2 commits July 28, 2026 07:40

fix: use the renamed android-sdk generator option

c2f670e

The backend generator's SDK option was renamed androidSdk -> android-sdk during review before landing on master. Update the invocation to match, otherwise generate-client fails with `kotlin: unknown option "androidSdk"`.

gpunto force-pushed the chore/openapi-generation-opt-flags branch from c16aff8 to c2f670e Compare July 28, 2026 07:40

coderabbitai Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread generate_openapi_v2.sh

gpunto added 2 commits July 28, 2026 08:33

fix: default the openapi generator to clone master

ca4673a

The Gradle task's default refValue still pointed at the merged (now-deleted) feature branch, so `generateOpenApiClient` would fail at `git clone --branch`. Default to master, matching the script's own default and the intended source.

rahul-lohra approved these changes Jul 28, 2026

View reviewed changes

gpunto merged commit 0600b65 into develop Jul 28, 2026
17 checks passed

gpunto deleted the chore/openapi-generation-opt-flags branch July 28, 2026 09:49

PratimMallick mentioned this pull request Aug 4, 2026

chore: merge develop into develop-v2 #1761

Open

27 tasks

stream-public-bot added the released Included in a release label Aug 5, 2026

Navigation Menu

Uh oh!

chore: pass OpenAPI generator config via --opt flags - #1743

chore: pass OpenAPI generator config via --opt flags#1743
gpunto merged 4 commits into
developfrom
chore/openapi-generation-opt-flags

gpunto commented Jul 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

coderabbitai Bot commented Jul 28, 2026

Review ran into problems

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jul 28, 2026

Uh oh!

rahul-lohra left a comment

Uh oh!

Uh oh!

stream-public-bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

gpunto commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Implementation

🎨 UI Changes

Testing

☑️Contributor Checklist

General

Code & documentation

Uh oh!

github-actions Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist ✅

Uh oh!

github-actions Bot commented Jul 10, 2026

SDK Size Comparison 📏

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

coderabbitai Bot commented Jul 28, 2026

Walkthrough

Changes

Review ran into problems

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jul 28, 2026

Quality Gate passed

Uh oh!

rahul-lohra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stream-public-bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gpunto commented Jul 10, 2026 •

edited

Loading

github-actions Bot commented Jul 10, 2026 •

edited

Loading