Patch v2 with E2E improvements - #1760
Closed
rahul-lohra wants to merge 1 commit into
Closed
Conversation
…atency (#1751) * test(e2e): harden recording and outgoing-call waits against backend latency The composite recorder can take 20-30s to start and emit call.recording_started, and the outgoing ringing screen only renders after the call create/ring network round-trip. The 5s default (recording icon) and 10s (outgoing decline button) waits time out before the UI appears, causing deterministic findObject NPEs in testParticipantRecordsCall and testUserRejectsTheOutgoingAudioCall. Co-authored-by: Cursor <cursoragent@cursor.com> * test(e2e): extend recording-consent and stop waits to 30s The recording-consent dialog (acceptCallRecording/declineCallRecording) and the recording-icon disappear assert are all gated on backend recorder events (call.recording_started / call.recording_stopped), which can take 20-30s. The 10s/5s waits time out first, so testParticipantRecordsCall still failed at acceptCallRecording after the initial icon-wait bump. Extend these waits to 30s. Co-authored-by: Cursor <cursoragent@cursor.com> * test(e2e): record for 60s so the recording icon is observable Composite recording spins up ~10-15s after the request, so recording for only 15s left a ~5s client-visible window that closed before the 3-view assertion loop could observe the icon. Record for 60s and keep the buddy in the call for 120s (matching the ReconnectionTests pattern) so the icon is reliably visible, then extend the "recording disappeared" wait to 70s to cover the longer run. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
PR checklist ❌The following issues were detected:
What we check
|
Contributor
SDK Size Comparison 📏
|
|
Contributor
Author
|
Not needed, we are proceeding with #1761 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Patch v2 with E2E improvements
Just increase timeouts of E2E tests
Implementation
Reference PR: #1751
🎨 UI Changes
None
Testing
None