Repository navigation
Conversation
The client comes from chat master's generator (sealed event unions, enum types without fromJson/toJson, runApiSafely call adapter) and the latest spec, which names one enum per concept. generate.sh now builds the generator from chat's tools/openapi. The error composer reads a mapped coordinator failure's DioException, so the error still names the request. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
📊 Cognitive Complexity AnalysisNet Delta: +7 | Added: 5 | Increased: 1 | Improved: 2 | Removed: 3 | Violations: 0
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #1536 +/- ##
==========================================
+ Coverage 53.52% 53.53% +0.01%
==========================================
Files 470 470
Lines 32800 32799 -1
==========================================
+ Hits 17555 17558 +3
+ Misses 15245 15241 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
It runs code generation, analysis and every test. Recent runs took up to 14 minutes against a 15-minute limit, and the regenerated client adds about two more. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
SDK Size
Measured on |
Size BreakdownWhat each SDK adds to an empty release app, per Dart package and native library. Dart sizes are uncompressed symbol sizes. Open the This run does not measure ios. Measured on android ·
|
| Component | Size | Δ vs v2 |
|---|---|---|
native:libjingle_peerconnection_so.so |
11.96 MB | 0 |
package:stream_video |
1.08 MB | +0.5 KB |
classes.dex |
261.9 KB | 0 |
dart:@unknown |
256.3 KB | -0.4 KB |
dart:_http |
153.9 KB | +0.0 KB |
package:protobuf |
146.0 KB | -0.1 KB |
dart:mixin_deduplication |
137.3 KB | +0.3 KB |
native:libdartjni.so |
121.7 KB | 0 |
dart:io |
99.3 KB | +0.0 KB |
dart:async |
75.6 KB | -0.0 KB |
package:stream_core |
69.2 KB | +0.5 KB |
package:stream_webrtc_flutter |
56.3 KB | -0.0 KB |
package:rxdart |
54.3 KB | +0.0 KB |
dart:core |
52.2 KB | +0.8 KB |
package:dio |
51.8 KB | +0.0 KB |
| other (71) | 537.0 KB | +0.2 KB |
android · stream_video_flutter: 17.37 MB (+1.0 KB)
| Component | Size | Δ vs v2 |
|---|---|---|
native:libjingle_peerconnection_so.so |
11.96 MB | 0 |
package:stream_video |
1.13 MB | +0.0 KB |
package:flutter |
699.0 KB | +0.0 KB |
classes.dex |
454.8 KB | 0 |
dart:@unknown |
431.1 KB | -0.3 KB |
dart:mixin_deduplication |
356.4 KB | +0.4 KB |
package:stream_video_flutter |
205.5 KB | +0.0 KB |
dart:_http |
154.3 KB | -0.0 KB |
package:protobuf |
145.6 KB | +0.1 KB |
dart:io |
136.4 KB | -0.0 KB |
package:stream_core_flutter |
124.2 KB | -0.0 KB |
native:libdartjni.so |
121.7 KB | 0 |
assets |
118.5 KB | 0 |
package:hive_ce |
99.2 KB | -0.0 KB |
dart:@shared |
83.6 KB | +0.2 KB |
| other (98) | 1.22 MB | +0.5 KB |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the coordinator client from the latest spec with chat master's generator, which now includes GetStream/chat#19582 (FEEDS-2158).
scripts/generate.shbuilt the generator fromprojects/chat-manager, which chat no longer has; it now buildstools/openapi.Generator
model/events.dart. BothcapabilitiesByRolemodels are now in that one library, sogenerate.shinserts its helper once.fromJson/toJson; call sites use the constructor.runApiSafely, so a failed request arrives as aStreamException. The error composer composes from itsDioExceptioncause when that is a coordinator request, so the error still names the request; a token-endpoint failure keeps its own message.ConnectedEventis a core model the generator leaves out, soconnection.okreads its two fields directly.Spec
FeatureActivationMode,TranscriptionLanguage,AudioDefaultDevice,CameraFacing,VideoCodec,PushProviderName,RecordingType, …. Call sites, mappers and tests move to them, and the…Enumaliases point at them.RecordingTypeis hidden from the export, sincestream_videohas its ownRecordingTypeenum;CallRecordingTypenames it.fpsandchannelsareints;CallSettingsResponse.lifecycleandOwnUserResponse.blockedUserIdsare required, so the test fixture carrieslifecycle.CHANGELOG entries are relative to v1.7.2.
The
analyzeCI job, which also runs every test, gets 25 minutes instead of 15: recentv2runs already took up to 14 minutes, and the larger client adds about two.Tested
dart analyze --fatal-infos: the same issues asorigin/v2in every package, none in changed lines.stream_video: all 1702 tests pass, including two new composer tests for a mapped coordinator failure and a mapped token failure.stream_video_flutter: the same 106 golden failures asorigin/v2on this machine, no others.stream_video_push_notification: all 84 tests pass.🤖 Generated with Claude Code