Repository navigation
Test closing a never-opened connection - #379
Merged
Merged
Conversation
Coverage Report for CI Build 39425920399Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage at 92.58% (no base build to compare)Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
alaricd
added a commit
to pengdows/pengdows.AdoNetApiTest.conformance
that referenced
this pull request
Oct 20, 2026
…ises nothing The asynchronous tests were behind #if NETSTANDARD2_1_OR_GREATER, which the net10.0 build does not define, so nine Required tests never ran there and the runner's catalog, read from that build, left them out. They are now behind #if !NETSTANDARD2_0, and a repository test checks they are in the net10.0 build. StateChange "occurs when the state of the connection changes from closed to opened or from opened to closed", so closing a closed connection must not raise it (Required). Close and CloseAsync on a connection never opened are Common, since no page covers Close before Open; DuckDB.NET added the same test (Giorgi/DuckDB.NET#379). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the requested regression coverage for a connection that was never opened. The test verifies that Close() and CloseAsync() do not throw, the state remains Closed, and StateChange is not raised.\n\nVerified with the targeted test: passed.