Skip to content

fix: avoid duplicate settings in RID tool dispatcher - #5384

Closed
arturcic wants to merge 4 commits into
GitTools:mainfrom
arturcic:codex/deduplicate-tool-settings
Closed

arturcic wants to merge 4 commits into
GitTools:mainfrom
arturcic:codex/deduplicate-tool-settings

Conversation

@arturcic

@arturcic arturcic commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

The .NET 11 RC2 tool-pack step emits NU5118 on Windows, Linux and macOS because both target frameworks contribute tools/any/any/DotnetToolSettings.xml to the RID dispatcher package. Keep that framework-independent file from the first target framework only; retain every framework-specific settings file in the RID implementation packages. Treat NU5118 as an error when packing the tool so duplicate package paths cannot silently return.

This is the second SDK audit follow-up for #5210 and depends on #5383. Review commit 3965f9c95 for this change; the branch includes its predecessor until #5383 merges. GitHub native stacks do not support fork PRs, so this dependency is tracked here. It preserves net10/net11 targeting and package layout; no warning suppression or test-runner migration is included.

Validation:

  • Reproduced NU5118 with RC2 in a minimal net10/net11 RID tool package; the fix removes the warning and preserves the generated settings files byte-for-byte.
  • Verified single-framework and portable multi-framework packages retain their settings.
  • Packed the real GitVersion tool for macOS arm64 with NU5118 treated as an error, and installed/launched it using SDK 10 and SDK 11 RC2.
  • git diff --check passed; CodeRabbit CLI reviewed the change with zero findings.

Full distro/architecture packaging and artifact validation remains for CI.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@arturcic

Copy link
Copy Markdown
Member Author

Replaced by arturcic#1027, targeting codex/process-capture-net11 in the fork as requested. The replacement includes the docs build race fix (8d143b6). GitHub native stacks cannot include fork PRs; the replacement expresses the dependency directly through its base branch.

@arturcic arturcic closed this Oct 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant