Repository navigation
Make next gix-transport test GIX_TEST_FIXTURE_HASH-aware - #3059
Merged
Sebastian Thiel (Byron) merged 3 commits intoOct 14, 2026
Merged
Sebastian Thiel (Byron) merged 3 commits into
Sebastian Thiel (Byron) merged 3 commits into
Conversation
Christoph Rüßler (cruessler)
marked this pull request as ready for review
October 13, 2026 19:59
Christoph Rüßler (cruessler)
changed the title
GIX_TEST_FIXTURE_HASH-awaregix-transport test GIX_TEST_FIXTURE_HASH-aware
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Byron
approved these changes
Oct 14, 2026
Byron
left a comment
Byron
left a comment
Member
There was a problem hiding this comment.
Thanks a lot! I love how this new baseline can be extended and am already looking forward to future follow-ups.
The changes to the test look quite elaborate and I don't say I understand every detail of it, after all, one would have to have a mental picture of what's contained in the baseline files. Did you write that entirely unassisted? If not, it's probably time to use something like the Assisted-by: <agent identity> commit message trailer.
Sebastian Thiel (Byron)
force-pushed
the
run-gix-transport-tests-with-sha-256-2
branch
from
October 14, 2026 03:25
bc0d94a to
bdca714
Compare
This commit replaces the previously hard-coded fixture that only exercised SHA-1 by extending the fixture script added in 951b9fc. The fixture script runs `git upload-pack` to generate the expected message.
…tured baselines <!-- agent --> A flaky Windows fetch test failed while generating `make_remote_repos.sh`, before the worktree assertions ran. The fixture output stopped after cloning `credential-helpers`, leaving no failing command or process exit status to explain the abort. Expected merge conflicts earlier in the script further obscured where setup actually failed. Enable `set -x` by default for `.sh` fixtures on Bash 4.1 and newer. Route traces through `BASH_XTRACEFD` to a duplicate of the original stderr, so commands that redirect stderr into fixture baselines do not capture tracing output. Keep successful fixture generation quiet by retaining the runner's existing policy of printing captured output only on failure. Bash 3.2, including the version shipped with macOS, cannot redirect xtrace independently of stderr. Use an inherited `ERR` trap there to report the failed command, script location, and status through the same descriptor. Include the subprocess exit status in the runner's error on every platform. Add coverage for silent command lookup failures, unchanged redirected stderr baselines, and exit statuses in fixture errors. This improves diagnosis; it does not identify or fix the original Windows flake. Assisted-by: GPT 6.1 Sol Co-authored-by: GPT 6.1 Sol <codex@openai.com>
Sebastian Thiel (Byron)
force-pushed
the
run-gix-transport-tests-with-sha-256-2
branch
from
October 14, 2026 04:25
bdca714 to
d839468
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the previously hard-coded fixture for the
handshake_v1_and_requesttest that only exercised SHA-1 by extending the fixture script added in 951b9fc. The fixture script runsgit upload-packto generate the expected message.This PR is a follow-up to #3043.