-
Notifications
You must be signed in to change notification settings - Fork 16
V0.13 support #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
V0.13 support #110
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9ca0364
feat(compatibility): align schema evolution with GTS 0.13
aviator5 47ad07d
fix(gts-id): distinguish v0 from wildcard versions
aviator5 6a8d744
fix: correct directional schema compatibility checks
aviator5 d3040c2
fix: Align schema compatibility with JSON Schema semantics
aviator5 6c0fcc6
fix(traits): Stop materializing const values
aviator5 3e712ee
fix(macros): Preserve explicit additional properties models
aviator5 f887d22
fix: localize unprovable schema intersections
aviator5 bd483dd
refactor(schema): Separate derivation from evolution checks
aviator5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| v0.12.2 | ||
| v0.13.1 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MEDIUM
GtsIdSegmentParts::ver_major() still collapses the now-Option field to 0 for an unspecified version, keeping the exact "unspecified vs real v0" conflation this PR had to fix in GtsIdPattern::matches_views, and GtsIdSegment::ver_major/GtsIdPatternSegment::ver_major propagate it to the public API.
Delete the three ver_major() -> u32 accessors (or mark them #[deprecated]) and make ver_major_opt() the only public major-version accessor, as SegmentView already does.