Repository navigation
fix(dialogs): keep pop-ups open when dragging outside - #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selecting text or dragging from inside Find a card or another affected pop-up no longer closes it when the mouse is released outside. Deliberate outside clicks still close the pop-up, and Settings still asks before discarding unsaved changes.
Type of change
Technical details
Testing performed
npm test npm run build npx prettier --check src/lib/dialog-backdrop.ts tests/dialog-backdrop.test.ts git diff --checkBreaking changes
None.
Checklist
npm testandnpm run build.CHANGELOG.md.