Repository navigation
fix(artboard): prevent accidental duplicates when dragging placed cards - #105
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking and dragging a card already on the artboard could start a browser image drag. Dropping that image onto the artboard could upload it again and add an accidental duplicate. Placed cards now stay on the sheet when dragged, while clicking still opens the artwork preview and dropping external image files still adds artwork.
Type of change
Technical details
Testing performed
npm test npm run buildAll 188 tests passed, and the production build completed successfully.
Playwright browser validation confirmed that a mouse drag on a placed image was canceled, the card count remained unchanged, and the upload overlay did not appear. A normal click opened the artwork dialog. A simulated external PNG file drop displayed the upload overlay, added one card, and cleared the overlay afterward. After merging the latest main, browser checks reconfirmed canceled image drags and artwork clicks, and verified that right-button dragging over a card still pans the preview and stops on release.
Breaking changes
None.
Checklist
npm testandnpm run build.CHANGELOG.md.