Repository navigation
Increase session timeout values in session.py - #201
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the timeouts for session creation and availability checks in google/cloud/managed_spark_connect/session.py. Specifically, the progress bar timeout is doubled to 1200 seconds, and the default timeout for waiting for a session to become available is increased to 600 seconds. The review feedback suggests optimizing the session availability check by monitoring the session state inside the polling loop, allowing the client to fail early and avoid blocking for the full 10 minutes if the session enters a terminal state such as FAILED or TERMINATED.
Add error handling for session state before Spark Connect endpoint availability.
Increased the timeout duration for session availability from 600 to 1200 seconds.
dborowitz
approved these changes
Oct 15, 2026
dborowitz
left a comment
dborowitz
left a comment
Contributor
There was a problem hiding this comment.
LGTM, though I think in reality there is no upper bound when we're dealing with stockouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some sessions may take a longer time to start (5+ minutes), but they start successfully. This change increases the timeouts to match the backend, but also checks if the session has failed or been terminated in between