refactor: remove region_tags redudancy on Endpoints Kubernetes tutorial#10284
refactor: remove region_tags redudancy on Endpoints Kubernetes tutorial#10284Kef131 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes several region tag comments (such as # [START ...] and # [END ...]) from the Kubernetes deployment configuration file esp_echo_http.yaml. I have no feedback to provide as there are no review comments and the changes are straightforward cleanup.
|
Here is the summary of changes. You are about to delete 3 region tags.
This comment is generated by snippet-bot.
|
amcolin
left a comment
There was a problem hiding this comment.
These changes look good to me. I’ve validated that none of these region tags are in use, and since the file isn't referenced anywhere, removing the entire file as a cleanup should be fine to ensure there’s no orphaned code.
Description
Fixes # b/384511454
Removed these region tags, due they are not used on cloud java Endpoints samples.
endpoints_secret1_yaml_javaendpoints_service_yaml_javaendpoints_secret2_yaml_javaPlease go to b/384511454 for context and support of this PR.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only