Skip to content

refactor: remove region_tags redudancy on Endpoints Kubernetes tutorial#10284

Open
Kef131 wants to merge 1 commit into
mainfrom
cleanup(endpoints)-remove_unused_region_tags
Open

refactor: remove region_tags redudancy on Endpoints Kubernetes tutorial#10284
Kef131 wants to merge 1 commit into
mainfrom
cleanup(endpoints)-remove_unused_region_tags

Conversation

@Kef131

@Kef131 Kef131 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes # b/384511454
Removed these region tags, due they are not used on cloud java Endpoints samples.

  • endpoints_secret1_yaml_java
  • endpoints_service_yaml_java
  • endpoints_secret2_yaml_java

Please go to b/384511454 for context and support of this PR.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: endpoints Issues related to the Cloud Endpoints API. labels Jun 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several region tag comments (such as # [START ...] and # [END ...]) from the Kubernetes deployment configuration file esp_echo_http.yaml. I have no feedback to provide as there are no review comments and the changes are straightforward cleanup.

@Kef131 Kef131 marked this pull request as ready for review June 18, 2026 16:46
@Kef131 Kef131 requested review from a team and yoshi-approver as code owners June 18, 2026 16:46
@snippet-bot

snippet-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I’ve validated that none of these region tags are in use, and since the file isn't referenced anywhere, removing the entire file as a cleanup should be fine to ensure there’s no orphaned code.

@Kef131 Kef131 self-assigned this Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants